Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt]: centralize logic to determine current page #3611

Open
emilydrakesmith opened this issue Mar 26, 2024 · 0 comments
Open

[Tech Debt]: centralize logic to determine current page #3611

emilydrakesmith opened this issue Mar 26, 2024 · 0 comments
Assignees
@emilydrakesmith
Labels
good first issue Good for newcomers low-prio technical debt This issue involves deferred engineering work

Comments

@emilydrakesmith
Copy link
Contributor

What is needed?

The Ambient app has a preponderance of code that runs only on certain pages (ie URL paths). This has led to a lot of local, repetitive logic to determine whether the user is (or is not) one of multiple pages which gatekeeps local logic.

The app should have one centralized method widely available to run these comparisons without logic duplication.

Example:
image
@emilydrakesmith emilydrakesmith added good first issue Good for newcomers technical debt This issue involves deferred engineering work low-prio labels Mar 26, 2024
@emilydrakesmith emilydrakesmith self-assigned this Mar 26, 2024
@emilydrakesmith emilydrakesmith mentioned this issue Mar 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilydrakesmith emilydrakesmith

Labels
good first issue Good for newcomers low-prio technical debt This issue involves deferred engineering work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add isPage() fn to useLinkGen() hook CrocSwap/ambient-ts-app
1 participant
@emilydrakesmith