Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework review + contribution ideas #109

Open
han-so1omon opened this issue Oct 20, 2023 · 5 comments
Open

Framework review + contribution ideas #109

han-so1omon opened this issue Oct 20, 2023 · 5 comments

Comments

@han-so1omon
Copy link
Contributor

I have conducted a review of this framework based on the available material from early September, 2023. Please see the review below. If possible, comment here or on the document which points are relevant to be turned into modifications and pull requests

Note that I work with the ICON Foundation

https://docs.google.com/document/d/1Xz2Z62IpQoySiAevR1aOoTVPlgVup7hflqgrLPq1JbU/edit?usp=sharing
@ermyas
Copy link
Collaborator

ermyas commented Oct 20, 2023

That's great! Thanks @han-so1omon!
I'll go through this shortly and get back with thoughts.

@han-so1omon
Copy link
Contributor Author

@ermyas Just checking in. Any updates on this?

@ermyas
Copy link
Collaborator

ermyas commented Oct 26, 2023

@han-so1omon I added some comments to the doc

@han-so1omon
Copy link
Contributor Author

Thank you. Will review and respond next week

@han-so1omon
Copy link
Contributor Author

I am actively working on the edits discussed in the document

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ermyas @han-so1omon