Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensor download modules #396

Merged
merged 16 commits into from
Aug 31, 2023
Merged

Sensor download modules #396

merged 16 commits into from
Aug 31, 2023

Conversation

carlosmmatos
Copy link
Contributor

This PR introduces the following additions/updates:

  • Addition of the sensor_download_info and sensor_download modules
  • Updates to the existing roles to take advantage of the new modules created thus far
  • Minor fixes
  • Doc updates

@carlosmmatos carlosmmatos added minor_changes New features, like plugin or module options devel Keep track of devel branch work labels Aug 25, 2023
@carlosmmatos carlosmmatos self-assigned this Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (devel@23c1177). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             devel     #396   +/-   ##
========================================
  Coverage         ?   44.37%           
========================================
  Files            ?       13           
  Lines            ?      489           
  Branches         ?       88           
========================================
  Hits             ?      217           
  Misses           ?      271           
  Partials         ?        1
Flag Coverage Δ
sanity 44.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@carlosmmatos
feat(sensor_download_info): adding new sensor_download_info module
792fc99
@carlosmmatos
chore(sensor_update_policy_info): update requirements and add new doc…
31e55a5 
… fragment
@carlosmmatos
chore(sensor_download_info): add to falcon_install role + minor updates
195d034
@carlosmmatos
feat(sensor_download): adding initial scaffold for new sensor_downloa…
0eef1e1 
…d module
@carlosmmatos
feat(sensor_download): adding code to module
1bf61f2
@carlosmmatos
doc(sensor_download): update verbiage
ea48a1f
@carlosmmatos
chore: reset module-test.yml
11fc010
@carlosmmatos
chore: add helper function for falconpy version check
da73dda
@carlosmmatos
fix(sensor_download): update verbiage and fix missing dest when file …
3a3c1ee 
…exists
@carlosmmatos
chore: add version check to existing modules
57bb602
@carlosmmatos
fix(falcon_install): major updates to falcon_install role to use new …
14e8dfd 
…modules
@carlosmmatos
lint: fix return types
29f4297
@carlosmmatos carlosmmatos marked this pull request as ready for review August 30, 2023 20:35
carlosmmatos
carlosmmatos commented Aug 31, 2023
View reviewed changes
plugins/doc_fragments/info.py
Comment on lines +3 to +4
# Copyright: (c) 2017, Ansible Project
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

plugins/module_utils/falconpy_utils.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update main README to include new modules

plugins/modules/sensor_download.py Outdated
options:
hash:
description:
- The SHA256 hash of the Falcon Sensor Installer.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add line along the lines:
this is the C(sha256) return value from the M(crowdstrike.falcon.sensor_download_info)

plugins/modules/sensor_download.py
- name: Download Windows Sensor Installer with custom name
crowdstrike.falcon.sensor_download:
hash: "1234567890123456789012345678901234567890123456789012345678901234"
dest: "/tmp/windows"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dest: "/tmp/windows"
path: "/tmp/windows"

evanstoner
evanstoner approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@evanstoner evanstoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1:1 and made some changes on the fly.

@evanstoner evanstoner added the ok-to-test Run tests label Aug 31, 2023
@carlosmmatos carlosmmatos added ok-to-test Run tests and removed ok-to-test Run tests labels Aug 31, 2023
@carlosmmatos carlosmmatos merged commit 157c651 into CrowdStrike:devel Aug 31, 2023
1 of 61 checks passed
@carlosmmatos carlosmmatos deleted the sensor-download-modules branch August 31, 2023 20:35
carlosmmatos added a commit that referenced this pull request Aug 31, 2023
@carlosmmatos
Sensor download modules (#396)
224363f 
Introduction of the sensor_download modules along with updates to install_role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffalor ffalor ffalor approved these changes

@evanstoner evanstoner evanstoner approved these changes

Assignees

@carlosmmatos carlosmmatos

Labels
devel Keep track of devel branch work minor_changes New features, like plugin or module options ok-to-test Run tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlosmmatos @codecov-commenter @evanstoner @ffalor