Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation for developing custom collectors #77

Open
1 task done
obvionaoe opened this issue Oct 8, 2022 · 2 comments
Open
1 task done

Better documentation for developing custom collectors #77

obvionaoe opened this issue Oct 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@obvionaoe
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

Improve the documentation for the API used to create custom collectors

How would you like to see this implemented?

In the wiki or maybe as a JavaDoc

Additional information to this request.

No response

@obvionaoe obvionaoe added the enhancement New feature or request label Oct 8, 2022
@Cubxity
Copy link
Owner

Cubxity commented Oct 8, 2022

@obvionaoe
Copy link
Author

Yes, I have, I just think some more docs could be added, like what the purpose of each function is as to allow developers to understand how they should implement them.
Something to help understand why that implementation isn't recommended for production and maybe the difference between async and non async collectors.
I believe you have implemented a good API, but without some extra documentation it might be hard for other developers to understand the purpose of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants