Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to use versions that support Node.js16 #572

Closed
de-husk opened this issue Dec 14, 2022 · 3 comments
Closed

Update github actions to use versions that support Node.js16 #572

de-husk opened this issue Dec 14, 2022 · 3 comments
Labels
good-first-issue Issue that is good for first.

Comments

@de-husk
Copy link
Contributor

de-husk commented Dec 14, 2022

Github is going to drop support for actions running <NodeJS 16 by "Summer 2023".

You can see the deprecation warnings in the CI job summaries.

Sadly we need to entirely stop using actions-rs/cargo as it has been confirmed to be no longer maintained will just stop working.

@de-husk de-husk added the good-first-issue Issue that is good for first. label Dec 14, 2022
@de-husk
Copy link
Contributor Author

de-husk commented Dec 14, 2022

Looks like https://github.com/dtolnay/rust-toolchain is a good alternative.

@JakeHartnell
Copy link
Member

Don't think this is relevant anymore?

@dtolnay
Copy link

dtolnay commented Jul 5, 2023

@JakeHartnell, still relevant. This never got fixed. The current main branch (currently 9261bb3) still has actions-rs/cargo multiple places in its CI. The CI job summaries are still showing piles of alerts about this problem.

- name: Run tests
uses: actions-rs/cargo@v1
with:
toolchain: nightly
command: unit-test
args: --locked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Issue that is good for first.
Projects
None yet
Development

No branches or pull requests

3 participants