Skip to content

Commit

Permalink
#2092: message: fix missing moves
Browse files Browse the repository at this point in the history
  • Loading branch information
lifflander authored and stmcgovern committed Apr 26, 2023
1 parent df36ee0 commit aad6f2d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/vt/vrt/context/context_vrtmanager.impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ messaging::PendingSend VirtualContextManager::sendSerialMsg(
innermsg->setProxy(toProxy);
theLocMan()->vrtContextLoc->routeMsgHandler<
SerialMsgT, SerializedMessenger::payloadMsgHandler
>(toProxy, home_node, innermsg);
>(toProxy, home_node, std::move(innermsg));
return messaging::PendingSend(nullptr);
},
// custom data transfer lambda if above the eager threshold
Expand Down Expand Up @@ -279,7 +279,7 @@ messaging::PendingSend VirtualContextManager::sendMsg(
[=](MsgPtr<BaseMsgType> mymsg){
// route the message to the destination using the location manager
auto msg_shared = promoteMsg(reinterpret_cast<MsgT*>(mymsg.get()));
theLocMan()->vrtContextLoc->routeMsg(toProxy, home_node, msg_shared);
theLocMan()->vrtContextLoc->routeMsg(toProxy, home_node, std::move(msg_shared));
}
);
}
Expand Down
2 changes: 1 addition & 1 deletion tests/perf/make_runnable_micro.cc
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ struct NodeObj {

void perfRunBenchmark() {
for (int i = 0; i < num_iters; i++) {
auto r = runnable::makeRunnable(msgs[i], false, han, 0)
auto r = runnable::makeRunnable(std::move(msgs[i]), false, han, 0)
.withContinuation(nullptr)
.withTDEpochFromMsg(false);
r.enqueue();
Expand Down

0 comments on commit aad6f2d

Please sign in to comment.