Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for minimum phase of historical LB data to retain #1934

Open
PhilMiller opened this issue Aug 24, 2022 · 1 comment · May be fixed by #1996
Open

Add configuration for minimum phase of historical LB data to retain #1934

PhilMiller opened this issue Aug 24, 2022 · 1 comment · May be fixed by #1996
Assignees
@cwschilly
Labels
intro A potentially good introductory issue for a new developer to address type: task

Comments

@PhilMiller
Copy link
Member

What Needs to be Done?

Right now, the number of phases worth of historical LB data that the system retains is based on how many the installed load model says it wants to use. We should add a configuration parameter to set a minimum retention, independent of the load model. This will support later programmatic use of historical data, like outputting based on some trigger event/observation, with historical data before activation for context.

Is your feature request related to a problem? Please describe.

Describe potential solution outcome

Describe alternatives you've considered

Additional context
@PhilMiller PhilMiller added the intro A potentially good introductory issue for a new developer to address label Sep 13, 2022
@PhilMiller
Copy link
Member Author

Likely a variable an relevant methods in LBManager, which would be used alongside calls to the active load model's method to report necessary history.

@nmm0 nmm0 mentioned this issue Sep 27, 2022
Open
thearusable added a commit that referenced this issue Oct 17, 2022
@thearusable
#1934: Add parameter to control minimal retention of historical LB data
20f1561
@thearusable thearusable linked a pull request Oct 17, 2022 that will close this issue
Open
thearusable added a commit that referenced this issue Oct 18, 2022
@thearusable
#1934: Add new fields to serialize methods
18157b5
thearusable added a commit that referenced this issue Oct 18, 2022
@thearusable
#1934: Add UTs for minimal LB data retention
edf8c23
thearusable added a commit that referenced this issue Oct 20, 2022
@thearusable
#1934: Always use min_hist_lb_data_ instead of value form model
76f3f8c
thearusable added a commit that referenced this issue Oct 25, 2022
@thearusable @cz4rs
#1934: Update comment in node_lb_data.h
84321c3 
Co-authored-by: Cezary Skrzyński <[email protected]>
thearusable added a commit that referenced this issue Oct 25, 2022
@thearusable @cz4rs
#1934: Update comments and test for lb_data_retention
1fa5810 
Co-authored-by: Cezary Skrzyński <[email protected]>
thearusable added a commit that referenced this issue Oct 25, 2022
@thearusable
#1934: Remove unused variable in test
181ce43
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable
#1934: Add parameter to control minimal retention of historical LB data
a5097ea
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable
#1934: Add new fields to serialize methods
0104661
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable
#1934: Add UTs for minimal LB data retention
034dcdf
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable
#1934: Always use min_hist_lb_data_ instead of value form model
bd9cddc
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable @cz4rs
#1934: Update comments and test for lb_data_retention
b0f7dac 
Co-authored-by: Cezary Skrzyński <[email protected]>
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable
#1934: Remove unused variable in test
2c5fd3b
thearusable added a commit that referenced this issue Oct 27, 2022
@thearusable
#1934: Cleanup of NodeLBData interface
1422bbc
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable
#1934: Add parameter to control minimal retention of historical LB data
d8dda94
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable
#1934: Add new fields to serialize methods
11cf984
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable
#1934: Add UTs for minimal LB data retention
df06149
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable
#1934: Always use min_hist_lb_data_ instead of value form model
d036ecd
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable @cz4rs
#1934: Update comments and test for lb_data_retention
434b53f 
Co-authored-by: Cezary Skrzyński <[email protected]>
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable
#1934: Remove unused variable in test
9962e6a
thearusable added a commit that referenced this issue Nov 11, 2022
@thearusable
#1934: Cleanup of NodeLBData interface
0b5ee2e
thearusable added a commit that referenced this issue Dec 6, 2022
@thearusable
#1934: Add parameter to control minimal retention of historical LB data
b4a686a
thearusable added a commit that referenced this issue Dec 6, 2022
@thearusable
#1934: Add new fields to serialize methods
7c591b2
thearusable added a commit that referenced this issue Dec 6, 2022
@thearusable
#1934: Add UTs for minimal LB data retention
ccecab0
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Add tests for front and back methods
4af903f
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update usage of circular phases buffer
1822f20
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Add resizing functionality to LBDataHolder buffers
f252c53
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update unit tests to use new constructor of LBDataHolder
f519dca
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Disable resizing of the buffer to zero
fef230b
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update tests to work correctly with the new buffer type
35fc771
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update implementation of circular buffer to work based on modu…
5c34790 
…lo operation
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update tests for circular buffer to support the new implementa…
14c17f3 
…tion
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update usage of the buffer in the codebase
5a94672
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update LBDataHolder to use default constructor
1d828ae
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Remove list initializer constructor
13b5d7f
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update LBDataHolder to resize containers when reading data fro…
b36b933 
…m json
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update tests to not use the removed constructor
7f3f0e1
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update usage of LBDataHolder in the codebase
77b8fb9
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Fix compilation issues after the PR rebase
3bc5550
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Reset ElementLBData containers after resetting the current phase
f4ce66b
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Remove leftovers from previous implementation of the circular …
c9c65e6 
…buffer
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Update CircularPhasesBuffer documentation
9a056c0
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Add resizeHistory method back after resolving conflicts
b9f2293
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Modify ElementLBData::resetPhase() to reset the head phase of …
57d0457 
…the containers rather than clearing their contents.
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Adapt newly added functionality in LBDataHolder to support Cir…
57b70f7 
…cularPhasesBuffer
thearusable added a commit that referenced this issue Sep 23, 2024
@thearusable
#1934: Remove comparison of signed and unsigned integers in retention…
ddc3c57 
… tests.
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#1934: Add LB data retention tests for chckpointing case
c6db957
thearusable added a commit that referenced this issue Sep 24, 2024
@thearusable
#1934: Improve documentation for CircularPhasesBuffer
a4ff0c6
thearusable added a commit that referenced this issue Sep 26, 2024
@thearusable
#1934: Modify test harness to allow for vt restarts
c9e9120
thearusable added a commit that referenced this issue Sep 26, 2024
@thearusable
#1934: Prepare content of the containers for work after restore from …
0623fc4 
…checkpoint
thearusable added a commit that referenced this issue Sep 26, 2024
@thearusable
#1934: Update retention test to do a full recreation of the vt objects
37b719f
thearusable added a commit that referenced this issue Sep 26, 2024
@thearusable
#1934: Fix retention test checks when LB is disabled
0b2489f
@ppebay ppebay assigned cwschilly and unassigned thearusable Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwschilly cwschilly

Labels
intro A potentially good introductory issue for a new developer to address type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1934: Add parameter to control minimal retention of historical LB data DARMA-tasking/vt
3 participants
@PhilMiller @thearusable @cwschilly