Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strong Node type across code base to prevent confusion #2099

Open
PhilMiller opened this issue Mar 10, 2023 · 0 comments · May be fixed by #2139
Open

Use strong Node type across code base to prevent confusion #2099

PhilMiller opened this issue Mar 10, 2023 · 0 comments · May be fixed by #2139
Assignees
@JacobDomagala

Comments

@PhilMiller
Copy link
Member 

          This should maybe be in a lower-level shared header, so that we're more able to use it across the codebase.

Originally posted by @PhilMiller in #2064 (comment)
@PhilMiller PhilMiller mentioned this issue Mar 10, 2023
Merged
@nmm0 nmm0 mentioned this issue Apr 25, 2023
Open
JacobDomagala added a commit that referenced this issue Apr 26, 2023
@JacobDomagala
#2099: Types: Make NodeType a strong type and use it across the codebase
c74bc82
@JacobDomagala JacobDomagala linked a pull request Apr 26, 2023 that will close this issue
Draft
JacobDomagala added a commit that referenced this issue Apr 26, 2023
@JacobDomagala
#2099: Types: Make NodeType a strong type and use it across the codebase
71381b4
JacobDomagala added a commit that referenced this issue Apr 26, 2023
@JacobDomagala
#2099: Types: Make NodeType a strong type and use it across the codebase
5a3e388
JacobDomagala added a commit that referenced this issue Apr 29, 2023
@JacobDomagala
#2099: Types: Add basic arithmetic operations and use them across cod…
8e1fb03 
…ebase
JacobDomagala added a commit that referenced this issue May 8, 2023
@JacobDomagala
#2099: Types: Make NodeType a strong type and use it across the codebase
db4b7d8
JacobDomagala added a commit that referenced this issue May 8, 2023
@JacobDomagala
#2099: Types: Add basic arithmetic operations and use them across cod…
e9ae484 
…ebase
JacobDomagala added a commit that referenced this issue May 8, 2023
@JacobDomagala
#2099: Tests: Fix failing test_destroy test
9b434a6
JacobDomagala added a commit that referenced this issue Jan 18, 2024
@JacobDomagala
#2099: Types: Make NodeType a strong type and use it across the codebase
d286a84
JacobDomagala added a commit that referenced this issue Jan 18, 2024
@JacobDomagala
#2099: Types: Add basic arithmetic operations and use them across cod…
2c337ea 
…ebase
JacobDomagala added a commit that referenced this issue Jan 18, 2024
@JacobDomagala
#2099: Tests: Fix failing test_destroy test
f34d636
JacobDomagala added a commit that referenced this issue Jan 18, 2024
@JacobDomagala
#2099: Make public API work as before
b8e2123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2099: Make NodeType a strong type and use it across the codebase DARMA-tasking/vt
2 participants
@PhilMiller @JacobDomagala