Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to integrate with Foundry World Time #121

Open
DC23 opened this issue Nov 18, 2024 · 2 comments
Open

Add option to integrate with Foundry World Time #121

DC23 opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
core feature A core planned feature
Milestone

Comments

@DC23
Copy link
Owner

DC23 commented Nov 18, 2024

This will allow unification with game systems and other modules that also use World Time.

It should be a module setting that can be enabled, with the default to keep this module separate.

@DC23 DC23 added this to the Beta +1 milestone Nov 18, 2024
@DC23
Copy link
Owner Author

DC23 commented Nov 18, 2024

Some technical effort will be required. There are different hooks to respond to for time change events, Foundry world time stores time in seconds, not time in minutes, and so on. I'll need to think about how to refactor towards this change with the minimal chance of bugs and disruption to the current code.

@DC23 DC23 self-assigned this Nov 18, 2024
@DC23 DC23 added the enhancement New feature or request label Nov 18, 2024
@DC23 DC23 modified the milestones: Beta +1, v1.0.0 Nov 19, 2024
@DC23 DC23 added core feature A core planned feature and removed enhancement New feature or request labels Dec 2, 2024
@DC23 DC23 modified the milestones: v1.0.0, v1.1.0 Dec 6, 2024
@DC23 DC23 modified the milestones: v1.2.0, v1.3.0 Dec 15, 2024
@DC23
Copy link
Owner Author

DC23 commented Dec 15, 2024

Simplest initial refactoring is to change my internal time calculation to store time in seconds since the epoch rather than minutes since the epoch. Having the same internal units should make future compatibility much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core feature A core planned feature
Projects
None yet
Development

No branches or pull requests

1 participant