Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering the project table no longer filters the project navigation tree #1010

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Filtering the project table no longer filters the project navigation tree #1010

wants to merge 4 commits into from

Conversation

jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented Jul 7, 2023 •
edited
Loading

Resolves: (#1003)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Separate projects collections and pagination controls from nav tree
  • Fix pagination so that it always returns a valid page (previously, if you delete the last item on the last page, it throws a 404 error)
  • Hide nav tree pagination controls after log out
  • Fix visual bug when updating projects caused by global collections being cleared before fetching

@jackyyzhang03 jackyyzhang03 linked an issue Jul 7, 2023 that may be closed by this pull request
[Rodan-client] Filtering the project table also filters the project navigation tree #1003
Open
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review July 7, 2023 15:38
@jackyyzhang03 jackyyzhang03 requested a review from cadagong July 7, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadagong cadagong Awaiting requested review from cadagong

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rodan-client] Filtering the project table also filters the project navigation tree
1 participant
@jackyyzhang03