Drum Sequencer Reset pattern always overwritten

[FogLizard]

Version

24.09

Plugin type

VST3

OS

Arch Linux

DAW / Host (if applicable)

Ardour 8.9.0

Description

Drum Sequencer DK from SV Modular upon Reset always overwrites first pattern bank with pattern from the bank where playback was stopped instead of just resetting to first pattern and first step when playback is restarted from auto return to marker. This bug makes one go back to plugin GUI to manually reset pattern back to the first one every time before starting playback or copy/pasting first bank every time to manually return to original overwritten pattern to fix this issue. This is extremely annoying and it makes iterative music development near impossible. Please fix this.

[dromer]

@FogLizard does this only occur in Cardinal or can you reproduce this in VCV Rack?

[FogLizard]

@dromer I've downloaded free VCV Rack 2.5.2 standalone and there are no drum sequencers. I have no idea how to check this, I don't have pro plugins or anything else to check.

[dromer]

This is not a "Pro" plugin, but an opensource one.

Can you share a patch that replicates the issue so others can test and confirm it?

[FogLizard]

Here's the patch. I can't find where to download the free VCV plugin.

[dromer]

We don't see the patch file anywhere. You will likely have to put it in a ZIP file, or you can upload it at patchstorage.com

For VCV you need to have an account and enable this module in the official library: https://library.vcvrack.com/DrumKit/Sequencer

[FogLizard]

Zip file gets rejected for some reason too. Patch is available by link below:
http://191.101.33.198/drum1.vcv

[dromer]

Thank you!

I'm trying to reproduce this in VCV and it seems that it is specific to Cardinal.

We have some minor patches to the DrumKit modules and I suspect that somehow this is breaking the behavior: SVModular/DrumKit@v2.0...CardinalModules:DrumKit:cardinal/v2.0.1#diff-7db98b71809cfb19499d5724bd2b6f4502e147ba7c235b900c3d5ce591beefbfR87-R94

[falkTX]

I think this is because of the currentPlay = 1; inside the doReset() call.
There was an issue due to this variable being unintialized but now seems also wrong to always reset it. So we should instead take it out of the doReset() again, and just give it a default value inside the class definition.
Actually this way we can also keep the old function contents as-is.