Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAP: add option to set supported dialect (e.g. CLAP_NOTE_DIALECT_MIDI_MPE) #441

Open
jfrey-xx opened this issue Dec 7, 2023 · 0 comments

Comments

@jfrey-xx
Copy link

jfrey-xx commented Dec 7, 2023

Hello,

Fist of all thank you for this framework, I'm creating my first audio plugins with it, and it's a breeze to get working my various synths / effects / utilities, with so many formats at once :)

I've been testing my plugins with the newly released Bitwig 5.1 (in Demo mode) and at the same time I wanted to try some things with pitch bend. I realized first that with 5.1 Bitwig now seems to acknowledge the CLAP_NOTE_DIALECT_MIDI flag, e.g. the "note on" events are not anymore processed through CLAP_EVENT_NOTE_ON in DistrhoPluginCLAP.cpp, but as regular MIDI events. The current workaround might probably stick for other cases. (I'll just refer to #383 (comment) if that can help to sort things).

The real issue I faced is that with 5.1 the pitch bend is not sent by bitwig anymore to my clap plugins (e.g. using the "fine" knob of the "note transpose" Note FX). For some reason I had to change at least the "supported" dialect flag in DistrhoPluginCLAP.cpp, from CLAP_NOTE_DIALECT_MIDI to CLAP_NOTE_DIALECT_MIDI_MPE. I guess this follows (odd?) Bitwig's behavior for the other formats (VST2 & VST3), where pitch bend is only sent if "MPE" is selected in the inspector. At my level I don't see any side effects, I would think that letting people choose the dialect flags offer more features to developers but I don't have the full picture.

To have the pitch bend perfectly usable in Bitwig I should also find a way to enable the selection of the pitch bend range in the DAW. There is no such option in inspector as compared to the VST plugins, and the host seems to default to +/- 48 semitones. I will handle that with a parameter at the plugin level, a good idea anyhow.

I spoke only of pitch bend, there might be other parameters (aftertouch?) that might be enabled in Bitwig through this MPE flag, I can do more testing if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant