-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: conversion op codes #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
execution
validation
tests
priority-high
priority-medium
labels
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
wucke13
reviewed
Aug 28, 2024
nerodesu017
force-pushed
the
feat/conversion-op-codes
branch
2 times, most recently
from
August 28, 2024 15:45
66a9880
to
0bb5f3a
Compare
nerodesu017
requested review from
valexandru,
wucke13,
george-cosma and
florianhartung
August 28, 2024 15:47
florianhartung
requested changes
Sep 3, 2024
nerodesu017
force-pushed
the
feat/conversion-op-codes
branch
from
September 4, 2024 07:34
0bb5f3a
to
4bc22b9
Compare
florianhartung
previously approved these changes
Sep 9, 2024
nerodesu017
force-pushed
the
feat/conversion-op-codes
branch
from
September 10, 2024 09:12
4bc22b9
to
ec682e6
Compare
nerodesu017
force-pushed
the
feat/conversion-op-codes
branch
from
September 10, 2024 09:19
ec682e6
to
894b769
Compare
Signed-off-by: nerodesu017 <[email protected]>
nerodesu017
force-pushed
the
feat/conversion-op-codes
branch
from
September 10, 2024 09:26
894b769
to
ad080ab
Compare
florianhartung
approved these changes
Sep 10, 2024
george-cosma
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds conversion op codes.
Testing Strategy
This pull request was tested using (almost) all related tests from the Wasm TestSuite
TODO or Help Wanted
N/A
Formatting
cargo fmt
cargo check
cargo build
cargo doc
nix fmt
Github Issue
This pull request partially implements #2