Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix break strict-aliasing rules warnings #639

Closed
howjmay opened this issue Jun 25, 2024 · 1 comment
Closed

fix break strict-aliasing rules warnings #639

howjmay opened this issue Jun 25, 2024 · 1 comment

Comments

@howjmay
Copy link
Collaborator

howjmay commented Jun 25, 2024 •
edited
Loading

When we run CI with optimization options, compiler would warn that the codebase break strict-aliasing rules.

see the CI https://github.com/DLTcollab/sse2neon/actions/runs/9658424846/job/26639574270?pr=638

There are some tests failed in the same CI. They may cause by the same reason
@jserv jserv mentioned this issue Jul 18, 2024
Merged
howjmay added a commit to howjmay/sse2neon that referenced this issue Jul 18, 2024
@howjmay
fix: Solve strict-aliasing errors
6e6a265 
Casting vector registers to a pointer or accessing the address of a
variable and then casting it to a different pointer type would
violate strict aliasing rules, potentially causing strict aliasing
errors.

`sse2neon_recast_u64_f64` and `sse2neon_recast_f64_s64` are introduced
to solve this error.

closes DLTcollab#635 DLTcollab#639
@jserv
Copy link
Member

jserv commented Jul 18, 2024

Close via #638

@jserv jserv closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jserv @howjmay