-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split for WF setups #161
Split for WF setups #161
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
aa47662
to
f1b9a05
Compare
@@ -0,0 +1 @@ | |||
../onprem/all.yml.example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense, if you know copy this symlink, you get another copy of the symlink right? And not the actual file.
Though I'm not sure how to do it better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vmcj@DESKTOP-QMUMFGG:/tmp$ touch original_file
vmcj@DESKTOP-QMUMFGG:/tmp$ ln -s original_file new_file
vmcj@DESKTOP-QMUMFGG:/tmp$ cp new_file new_2_file
vmcj@DESKTOP-QMUMFGG:/tmp$ ls -atrl | grep _file
-rw-r--r-- 1 vmcj vmcj 0 Sep 2 18:07 original_file
lrwxrwxrwx 1 vmcj vmcj 13 Sep 2 18:07 new_file -> original_file
-rw-r--r-- 1 vmcj vmcj 0 Sep 2 18:07 new_2_file
Not on my system, and my default script would create the needed file already. There is a python script next to it which autofills such example files to the actual yaml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then I'm mistaken 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickygerritsen so this is an approval? I tested and the syntax errors are now gone (so the only question is if we want this...)
We never use that files but generate clean secrets during deployment.
For the world finals we both test with an online and an onprem instance. We sometimes even manage an online server for the bigger contests together with a server which has no internet access. This also demonstrates to others using this how to setup something like even if we always only use 1 group on the location.
ce65ede
to
52ae9cf
Compare
There is no clean way to split the group and not share variables.
I encountered this when testing both the online and onprem hosts for the WF where variables can be different such as the network config. For BAPC/NAC/{N,S}NWERC & EUC we might have the same situations