Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOC has little todo with provisioning the contest #164

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Sep 2, 2024

Do we also still want to translate this to something in go or another quicker language?

@vmcj vmcj requested a review from tuupke September 2, 2024 20:40
@eldering
Copy link
Member

eldering commented Sep 2, 2024

While we move it, can it be renamed to something a bit more descriptive than EOC? For example, end-of-contest.

@vmcj
Copy link
Member Author

vmcj commented Sep 2, 2024

While we move it, can it be renamed to something a bit more descriptive than EOC? For example, end-of-contest.

I think everywhere for the finals/NAC we use EOC so in WF context it's quite descriptive, but I agree it's not clear outside of that context (but end-of-contest is also not that clear to me..), what do you think of backup-contest-package as that's mostly what it does?

So I'm fine with another name, I'm not sure what is a better name.

@eldering
Copy link
Member

eldering commented Sep 3, 2024

While we move it, can it be renamed to something a bit more descriptive than EOC? For example, end-of-contest.

I think everywhere for the finals/NAC we use EOC so in WF context it's quite descriptive, but I agree it's not clear outside of that context (but end-of-contest is also not that clear to me..), what do you think of backup-contest-package as that's mostly what it does?

So I'm fine with another name, I'm not sure what is a better name.

Well, end-of-contest is better than a TLA, but if what this does is to create a contest archive package, then sure go for backup-contest-package, but looking at the code, that's also not exactly what it does.

@eldering eldering merged commit 39002b2 into DOMjudge:main Sep 18, 2024
3 checks passed
@vmcj vmcj deleted the EOC_ansible_location branch September 25, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants