Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on adjusting Tag column width #64

Open
erldipin opened this issue Dec 8, 2023 · 1 comment
Open

Crash on adjusting Tag column width #64

erldipin opened this issue Dec 8, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Help wanted PR fixing this are welcome

Comments

@erldipin
Copy link

erldipin commented Dec 8, 2023

Describe the bug
After adjusting the width of all the other columns in List Layout view, I tried to make the tag column smaller and it crashed. On restart it lost all the metadata edits to the books and most of tags I had created.

To Reproduce

I've tried to reproduce the error but it hasn't crashed yet. I tried editing some of the metadata and added tags for a few minutes and adjusting the columns but it hasn't crashed again. Before, it had crashed after nearly an hour of working on it.

Screenshots/files
I've attached the all.log file. all.log

System info

  • OS: Windows 10 Pro 22H2
@erldipin erldipin added the bug Something isn't working label Dec 8, 2023
@github-project-automation github-project-automation bot moved this to Needs review in COMPASS Roadmap Dec 8, 2023
@DSPaul DSPaul moved this from Needs review to In Progress in COMPASS Roadmap Dec 8, 2023
@DSPaul
Copy link
Owner

DSPaul commented Dec 8, 2023

Hi there, I'm sorry to hear that. Currently COMPASS saves on close (and a few other triggers such as import) which suffices most of the time but it won't save when it crashes (to avoid corrupting your data), which can lead to these frustrating data losses.

Starting from the next update, I will make it save whenever you edit metadata or a tag to mitigate this problem, should have done that a long time ago.
As for the crash itself, looks like it tried to make the column infinite width which is impossible so it crashed. I'll see if I can try to catch that when it happens to prevent it in the future but it's likely a very rare thing. Doesn't surprise me that you weren't able to reproduce it.

@DSPaul DSPaul moved this from In Progress to Planned Long Term in COMPASS Roadmap Feb 9, 2024
@DSPaul DSPaul added the Help wanted PR fixing this are welcome label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Help wanted PR fixing this are welcome
Projects
Status: Planned Long Term
Development

No branches or pull requests

2 participants