Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive number of browse definition request on simple item page. #3700

Open
KoenP opened this issue Nov 29, 2024 · 1 comment · May be fixed by #3701
Open

Excessive number of browse definition request on simple item page. #3700

KoenP opened this issue Nov 29, 2024 · 1 comment · May be fixed by #3701
Assignees
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases high priority performance / caching Related to performance, caching or embedded objects

Comments

@KoenP
Copy link

KoenP commented Nov 29, 2024

Describe the bug

Each ItemPageFieldComponent performs a separate request to obtain potential browse indexes for the relevant metadata its relevant metadata fields.

To Reproduce

Go to a simple item page for an item with enough metadata to spawn multiple ItemPageFieldComponents.
In the browser's network log, observe the repeated GET requests to the http://localhost:8080/server/api/discover/browses/search/byFields?fields=... endpoint.
This slows down the page.

Expected behavior

Since all this information has already been requested for the "All of DSpace" navbar menu, we should be able to retrieve this information from the cache, rather than re-requesting it.

Related work

#3701

@KoenP KoenP added performance / caching Related to performance, caching or embedded objects needs triage New issue needs triage and/or scheduling labels Nov 29, 2024
@KoenP KoenP self-assigned this Nov 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Nov 29, 2024
@KoenP KoenP linked a pull request Nov 29, 2024 that will close this issue
12 tasks
@alanorth alanorth added high priority affects: main Issue impacts "main" (latest release). affects: 8.x Issue impacts 8.x releases affects: 7.x Issue impacts 7.x releases and removed needs triage New issue needs triage and/or scheduling labels Nov 29, 2024
@alanorth
Copy link
Contributor

Thanks @KoenP! I confirm I see lots of requests for /server/api/discover/browses/search/byFields?fields= on the simple item page of our DSpace 7.6 repository.

2024-11-29T19:14:52,618877707+03:00

Tagging this issue as affecting all current branches.

@tdonohue tdonohue removed this from DSpace Backlog Dec 2, 2024
@github-project-automation github-project-automation bot moved this to 📋 To Do in DSpace 9.0 Release Dec 2, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 9.0 Release Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: main Issue impacts "main" (latest release). affects: 7.x Issue impacts 7.x releases affects: 8.x Issue impacts 8.x releases high priority performance / caching Related to performance, caching or embedded objects
Projects
Status: 🏗 In Progress
Development

Successfully merging a pull request may close this issue.

2 participants