Added InfoAPI support #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
commented
Sep 12, 2021
| InfoAPI::provideInfo(self::class, StringInfo::class, "piggyfactions.faction.description", fn($info) => new StringInfo($info->faction->getDescription())); | ||
| InfoAPI::provideInfo(self::class, StringInfo::class, "piggyfactions.faction.motd", fn($info) => new StringInfo($info->faction->getMotd())); | ||
| InfoAPI::provideInfo(self::class, NumberInfo::class, "piggyfactions.faction.power", fn($info) => new NumberInfo($info->faction->getPower())); | ||
| InfoAPI::provideInfo(self::class, NumberInfo::class, "piggyfactions.faction.maxPower", fn($info) => new NumberInfo($info->faction->getMaxPower())); |
There was a problem hiding this comment.
Consider merging power and maxPower into a RatioInfo: https://github.com/SOF3/InfoAPI/blob/ae0e2ad01d3127c885d0d7bef9b9ec4d5fce9ebe/src/SOFe/InfoAPI/PlayerInfo.php#L80-L84
|
Don't merge it without testing. This is just a starting point for you to implement InfoAPI support. I recommend running a script plugin that calls |
This comment has been minimized.
This comment has been minimized.
|
oh shit |
|
What's wrong with your branches? |
# Conflicts: # .github/workflows/main.yml # .poggit.yml # plugin.yml # src/DaPigGuy/PiggyFactions/PiggyFactions.php # src/DaPigGuy/PiggyFactions/addons/hrkchat/TagManager.php # src/DaPigGuy/PiggyFactions/claims/ClaimsListener.php # src/DaPigGuy/PiggyFactions/commands/subcommands/claims/claim/ClaimCircleSubCommand.php # src/DaPigGuy/PiggyFactions/commands/subcommands/claims/claim/ClaimSquareSubCommand.php # src/DaPigGuy/PiggyFactions/commands/subcommands/claims/claim/ClaimSubCommand.php # src/DaPigGuy/PiggyFactions/commands/subcommands/claims/unclaim/UnclaimCircleSubCommand.php # src/DaPigGuy/PiggyFactions/commands/subcommands/claims/unclaim/UnclaimSquareSubCommand.php # src/DaPigGuy/PiggyFactions/event/FactionEvent.php # src/DaPigGuy/PiggyFactions/event/FactionMemberEvent.php # src/DaPigGuy/PiggyFactions/event/management/FactionCreateEvent.php # src/DaPigGuy/PiggyFactions/factions/Faction.php # src/DaPigGuy/PiggyFactions/factions/FactionsManager.php # src/DaPigGuy/PiggyFactions/players/FactionsPlayer.php # src/DaPigGuy/PiggyFactions/players/PlayerManager.php # src/DaPigGuy/PiggyFactions/tasks/ShowChunksTask.php # src/DaPigGuy/PiggyFactions/utils/AsciiMap.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure your pull request complies with these guidelines:
What does the PR change?
Provide InfoAPI support.
Testing Environment
Extra Information
Alright I didn't properly test this PR, but this is a good starting point if you want to introduce InfoAPI support.