You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The option authorizedRoles seems not to work properly. With the option set to admin for example, SimpleStats is still fully accessible for editor users. Only the option dismissDisclaimer => true set in site/config/config.php is ignored, meaning that the disclaimer dows show for editors.
Expected behavior
For unauthorized roles, SimpleStats should not be visible in the Panel menu.
My setup
Plainkit Kirby 3.6.1.1
Console output
code: 403
details: Array []
exception: "Kirby\\Exception\\PermissionException"
file: "api.php"
key: "error.permission"
line: 331
message: "You are not authorised to upgrade the db file."
route: "simplestats/mainview"
status: "error"
<prototype>: Object { … }
index.js:1:6814
I've very quickly implemented a protection method which is indeed unpolished.
The PermissionExceptions are seemingly correctly working, preventing data from being visible to unauthorized users.
Just the "interface hiding part" remains to be done.
Feel free to submit a PR or I'll polish this later.
It's not in the menu anymore, but there's still some roles polishing/checking to do, I'll consider this "bug" fixed.
Feel free to comment in #29 for permission-related feature requests.
Description
The option
authorizedRoles
seems not to work properly. With the option set toadmin
for example, SimpleStats is still fully accessible foreditor
users. Only the optiondismissDisclaimer => true
set insite/config/config.php
is ignored, meaning that the disclaimer dows show for editors.Expected behavior
For unauthorized roles, SimpleStats should not be visible in the Panel menu.
My setup
Plainkit Kirby 3.6.1.1
Console output
My system
The text was updated successfully, but these errors were encountered: