Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include former data in the remove audit entry #37

Open
fsalmen-nx opened this issue Jun 1, 2021 · 3 comments
Open

Include former data in the remove audit entry #37

fsalmen-nx opened this issue Jun 1, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@fsalmen-nx
Copy link

In a lot of use cases it would be really helpful to include the former data of a removed entity into the audit log. Right now the log only stores that an entity with a specific id was removed. If you for example, use the audit log to audit any user specific data, you might not be able to track for what exactly was deleted.

I would suggest to include the old values in the diff/changeset like it is done in the case of an update.

@fsalmen-nx fsalmen-nx added the enhancement New feature or request label Jun 1, 2021
@DamienHarper
Copy link
Owner

Hi @RiffFred, sorry for this late reply.
What exactly would you like to have in removal audit entries? It currently contains the id of the removed element and if a __toString() method exists in the relevant entity, it's also evaluated and its result is stored as well.

@fsalmen-nx
Copy link
Author

Hi @DamienHarper thank you for the reply.
I thought it might be helpful to include the full audited data of a removed element like it is done in the diff view for changed entities.
Maybe it is just a question of the different rendering between deleted and changed elements.
I think it would be nice to render something like element x was deleted and the element had the following data.
Basically like the diff view for changed elements but with only one site.
For new created elements the audit page also renders the exact data of the element.

If you think that this is not helpful or not doable i will play around with the __toString() implementation thank you for this hint.

@lorenzo-pezzali
Copy link

Hi,
also for me this is a good enhancement because i need to have all the fields of the deleted objects not only the __toString result.
Is it possible to implement this with a custom provider or some other way? Or the only method is to change the implementation of the bundle?

Thanks in advance for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants