Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with selection/highlight of nodes #31

Open
bjarnef opened this issue Oct 12, 2017 · 4 comments
Open

Issues with selection/highlight of nodes #31

bjarnef opened this issue Oct 12, 2017 · 4 comments

Comments

@bjarnef
Copy link

bjarnef commented Oct 12, 2017

It seems there are some issues with highligt of the nodes, e.g. sometimes it highlight "Trace Logs" node and I have to click twice to get one of the log nodes highlighted.

Furthermore when the routing has changed to e.g. /umbraco/#/developer/diploTraceLog/edit/CourierTraceLog.txt and I refresh browser, then the Trace Log nodes are collapsed.

I don't see this issue with e.g. LeBlender package, which has custom nodes under a "Grid Editors" root - also in developer section.

@DanDiplo
Copy link
Owner

OK, thanks, will look into it for the next release. I'll see if can nosey at LeBlender source code.

@bjarnef
Copy link
Author

bjarnef commented Oct 13, 2017

Looking at the source, it seems syncTree only trigger when selecting a node? Not when refreshing the page and routing is handled.

event.currentScope.nav.syncTree({
tree: $routeParams.tree,
path: buildPath(args.value, []),
forceReload: false
});

@DanDiplo
Copy link
Owner

Yes, that's probably the issue - good spot!

@DanDiplo
Copy link
Owner

I've tried to improve this in the current release, though it's not perfect. It will now refocus on the correct node after a full browser refresh.

There is a small issue in that when you select the filename version it highlights the date version. This is because the path is the same for both, so it can't distinguish between the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants