Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake -- Remove deprecated call to FetchContent_Populate(pico_sdk) #91

Open
henrygab opened this issue Sep 18, 2024 · 1 comment
Open
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@henrygab
Copy link
Collaborator

Seems to give a direct 1:1 replacement function.
This is just to track this for later PR.

CMake Warning (dev) at /usr/local/share/cmake-3.30/Modules/FetchContent.cmake:1953 (message):
  Calling FetchContent_Populate(pico_sdk) is deprecated, call
  FetchContent_MakeAvailable(pico_sdk) instead.  Policy CMP0169 can be set to
  OLD to allow FetchContent_Populate(pico_sdk) to be called directly for now,
  but the ability to call it with declared details will be removed completely
  in a future version.
Call Stack (most recent call first):
  cmake/pico_sdk_import.cmake:61 (FetchContent_Populate)
  CMakeLists.txt:49 (include)
@wyattearp
Copy link
Contributor

This is the same core issue as #92 sadly, by getting the correct picotool path items set ahead of time this should resolve itself.

@henrygab henrygab added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Sep 28, 2024
henrygab added a commit to henrygab/BusPirate5-firmware that referenced this issue Oct 11, 2024
Fixes DangerousPrototypes#91.

File comes from pico-sdk.
However, it's just a one-line change from
one API to another API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants