Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Core interface #33

Open
4 tasks
kkiani opened this issue Oct 7, 2024 · 0 comments
Open
4 tasks

Improving Core interface #33

kkiani opened this issue Oct 7, 2024 · 0 comments
Labels
feature/core-api Changes and suggestion to the core API interface

Comments

@kkiani
Copy link
Contributor

kkiani commented Oct 7, 2024

Damavand has come a long way since the beginning of the project. Some of the names and designs of the core/base classes and methods were originally based on ideas that are now either deprecated or have been replaced. This issue lists a set of small improvements and enhancements to the naming conventions and interfaces of Damavand's base/core classes to make them more intuitive:

  • Changing extra_args property on base controller to keyword_args to follow industry standard.
  • Changing the name of ApplicationController class to BaseController to prevent confusion.
  • Removing imports in the __init__.py files to prevent importing all features when importing one.
  • Replacing the use of @cache and @property decorators together with @cached_property.
@kkiani kkiani added the feature/core-api Changes and suggestion to the core API interface label Oct 7, 2024
@kkiani kkiani changed the title Improving Core interface namings Improving Core interface Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/core-api Changes and suggestion to the core API interface
Projects
None yet
Development

No branches or pull requests

1 participant