Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: run workflows for dependabot #32

Closed
wants to merge 9 commits into from

Conversation

Gandem
Copy link
Member

@Gandem Gandem commented Oct 24, 2024

What does this PR do?

Currently, we receive two successive actions when dependabot opens a PR, first an opened event, then a labeled event. the second event cancels the first workflow, however, we don't re-run tests when a PR is labeled except if the label is publish-dev-test. this fixes the issue by removing the cancel for all labels except publish-dev-test.

Peer investigated with @nsavoire, 🙇

Motivation

Run tests for PRs opened by dependabot!

Additional Notes

N/A

How to test the change?

N/A

currently, we receive two successive actions when dependabot opens a PR, first an `opened` event, then a `labeled` event. the second event cancels the first pipeline, however, we don't re-run tests when a PR is labeled except if the label is `publish-dev-test`. this fixes the issue by removing the cancel for all labels except `publish-dev-test`.
@Gandem Gandem requested a review from a team as a code owner October 24, 2024 15:17
@Gandem
Copy link
Member Author

Gandem commented Oct 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 24, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

Co-authored-by: Nicolas Savoire <[email protected]>
@Gandem Gandem requested a review from nsavoire October 24, 2024 15:20
@Gandem
Copy link
Member Author

Gandem commented Oct 24, 2024

/remove

@dd-devflow
Copy link

dd-devflow bot commented Oct 24, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Oct 24, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@Gandem Gandem added the bug Something isn't working label Oct 24, 2024
@Gandem Gandem added bug Something isn't working question Further information is requested and removed bug Something isn't working labels Oct 24, 2024
@@ -0,0 +1,15 @@
name: Labeled

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Code Vulnerability

No explicit permissions set for at the workflow level (...read more)

Datadog’s GitHub organization defines default permissions for the GITHUB_TOKEN to be restricted (contents:read, metadata:read, and packages:read).

Your repository may require a different setup, so consider defining permissions for each job following the least privilege principle to restrict the impact of a possible compromise.

You can find the list of all possible permissions in Workflow syntax for GitHub Actions - GitHub Docs. They can be defined at the job or the workflow level.

View in Datadog  Leave us feedback  Documentation

@Gandem Gandem added bug Something isn't working and removed publish-dev-test bug Something isn't working labels Oct 24, 2024
@Gandem Gandem added bug Something isn't working and removed bug Something isn't working labels Oct 24, 2024
@Gandem Gandem added bug Something isn't working question Further information is requested publish-dev-test and removed bug Something isn't working question Further information is requested labels Oct 24, 2024
@Gandem Gandem added bug Something isn't working and removed bug Something isn't working publish-dev-test labels Oct 24, 2024
@Gandem Gandem closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mergequeue-status: removed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants