From 02a349324af07a7e402d7e904d5edd9bd96a43f2 Mon Sep 17 00:00:00 2001
From: Federico Mon <federico.mon@datadoghq.com>
Date: Fri, 29 Nov 2024 17:51:04 +0100
Subject: [PATCH] test

---
 .../_taint_tracking/Aspects/AspectModulo.cpp  | 38 +++++++------------
 1 file changed, 14 insertions(+), 24 deletions(-)

diff --git a/ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectModulo.cpp b/ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectModulo.cpp
index a08f76d9f3d..1b26fd1f1bb 100644
--- a/ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectModulo.cpp
+++ b/ddtrace/appsec/_iast/_taint_tracking/Aspects/AspectModulo.cpp
@@ -2,7 +2,7 @@
 #include "Helpers.h"
 
 static PyObject*
-do_modulo(PyObject* text, PyObject* insert_tuple_or_obj)
+do_modulo(PyObject* text, PyObject* insert_tuple_or_obj, py::object py_candidate_text, py::object py_candidate_tuple)
 {
     PyObject* result = nullptr;
 
@@ -13,18 +13,22 @@ do_modulo(PyObject* text, PyObject* insert_tuple_or_obj)
         Py_INCREF(insert_tuple);
     } else {
         insert_tuple = PyTuple_Pack(1, insert_tuple_or_obj);
-        if (insert_tuple == nullptr) {
-            return nullptr;
-        }
     }
 
-    if (PyUnicode_Check(text)) {
+    if (PyUnicode_Check(text) && insert_tuple != nullptr) {
         result = PyUnicode_Format(text, insert_tuple);
-    } else if (PyBytes_Check(text) or PyByteArray_Check(text)) {
-        auto method_name = PyUnicode_FromString("__mod__");
-        result = PyObject_CallMethodObjArgs(text, method_name, insert_tuple, nullptr);
-        Py_DECREF(method_name);
     } else {
+        try {
+            py::object res_py = py_candidate_text.attr("__mod__")(py_candidate_tuple);
+            PyObject* res_pyo = res_py.ptr();
+            if (res_pyo != nullptr) {
+                Py_INCREF(res_pyo);
+            }
+            return res_pyo;
+        } catch (py::error_already_set& e) {
+            e.restore();
+            return nullptr;
+        }
     }
     Py_DECREF(insert_tuple);
     if (has_pyerr()) {
@@ -49,21 +53,7 @@ api_modulo_aspect(PyObject* self, PyObject* const* args, const Py_ssize_t nargs)
 
     // Lambda to get the result of the modulo operation
     auto get_result = [&]() -> PyObject* {
-        PyObject* res = do_modulo(candidate_text, candidate_tuple);
-        if (res == nullptr) {
-            try {
-                py::object res_py = py_candidate_text.attr("__mod__")(py_candidate_tuple);
-                PyObject* res_pyo = res_py.ptr();
-                if (res_pyo != nullptr) {
-                    Py_INCREF(res_pyo);
-                }
-                return res_pyo;
-            } catch (py::error_already_set& e) {
-                e.restore();
-                return nullptr;
-            }
-        }
-        return res;
+        return do_modulo(candidate_text, candidate_tuple, py_candidate_text, py_candidate_tuple);
     };
 
     TRY_CATCH_ASPECT("modulo_aspect", return get_result(), , {