Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build jruby-9.4 image with 9.4.7.0 version #3654

Merged
merged 2 commits into from
May 21, 2024

Conversation

anmarchenko
Copy link
Member

What does this PR do?
Updates outdated jruby-9.4 image to JRuby version version 9.4.7.0 by:

  • using eclipse-temurin:11-jammy as base image
  • installing 9.4.7.0 from maven
  • also it updates jruby image version in docker-compose

Motivation:
datadog-ci pipelines fail because of jruby incompatibility with latest versions of gems:

https://app.circleci.com/pipelines/github/DataDog/datadog-ci-rb?branch=main

How to test the change?

docker buildx build . -f Dockerfile-jruby-9.4.7.0 -t ghcr.io/datadog/dd-trace-rb/jruby:9.4.7.0-dd

docker compose run --rm tracer-jruby-9.4 /bin/bash

bundle exec rake ci

@anmarchenko anmarchenko requested a review from a team as a code owner May 21, 2024 09:25
Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anmarchenko anmarchenko merged commit 2507a83 into master May 21, 2024
156 of 165 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/new_jruby_9.4_image branch May 21, 2024 10:11
@github-actions github-actions bot added this to the 2.0.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants