-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-2507 Test individual product loading #3738
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
59ee7b5
require encapsulation test
p e07d58d
add missing requires to appsec
p b9c8128
run on push?
p 651702e
need ruby
p 8ea62d6
rubocop
p 73f1819
redo appsec requires
p cf2c5d3
redo test to use system
p 80f4465
remove added workflow
p ced882a
rubocop
p d4189c3
delete english require
p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
# frozen_string_literal: true | ||
|
||
require_relative 'configuration' | ||
require_relative '../core/configuration' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a dependency on Core::Configuration in this file. |
||
|
||
module Datadog | ||
module AppSec | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
require 'shellwords' | ||
|
||
REQUIRES = { | ||
'datadog/appsec' => 'Datadog::AppSec', | ||
'datadog/core' => 'Datadog::Core', | ||
'datadog/kit' => 'Datadog::Kit', | ||
'datadog/profiling' => 'Datadog::Profiling', | ||
'datadog/tracing' => 'Datadog::Tracing', | ||
}.freeze | ||
|
||
RSpec.describe 'loading of products' do | ||
REQUIRES.each do |req, const| | ||
context req do | ||
let(:code) do | ||
<<-E | ||
if defined?(Datadog) | ||
unless Datadog.constants == [:VERSION] | ||
exit 1 | ||
end | ||
end | ||
|
||
require "#{req}" | ||
|
||
unless defined?(#{const}) | ||
exit 1 | ||
end | ||
|
||
exit 0 | ||
E | ||
end | ||
|
||
it 'loads successfully by itself' do | ||
rv = system("ruby -e #{Shellwords.shellescape(code)}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey I didn't know |
||
expect(rv).to be true | ||
end | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individual contribs require the REGISTRY constant defined by top-level contrib.