Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Limit size of files in the crashinfo #564

Open
danielsn opened this issue Aug 1, 2024 · 0 comments
Open

[crashtracker] Limit size of files in the crashinfo #564

danielsn opened this issue Aug 1, 2024 · 0 comments

Comments

@danielsn
Copy link
Contributor

danielsn commented Aug 1, 2024

          Really unrelated to this PR, but I noticed that `CrashInfo::add_file` seems to read the entire file to memory before trying to do anything with its contents.

Perhaps it may be worth adding a hard limit there, in case we get fed the wrong thing? (Insert crowdstrike broken file joke/reference?)

Originally posted by @ivoanjo in #551 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant