Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trace-mini-agent] change logging crate #799

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[trace-mini-agent] change logging crate #799

wants to merge 2 commits into from
+9 −9

Conversation

duncanista
Copy link

What does this PR do?

Changes the logging crate from log to tracing

Motivation

So instrumentation can be controlled using tracing-subscriber

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@duncanista duncanista marked this pull request as ready for review December 12, 2024 18:02
@duncanista duncanista requested review from a team as code owners December 12, 2024 18:02
@pr-commenter
Copy link

pr-commenter bot commented Dec 12, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-12-12 18:16:25

Comparing candidate commit bc4ab43 in PR branch jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging with baseline commit 373b778 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.795µs 23.870µs ± 11.738µs 18.990µs ± 0.053µs 19.146µs 37.891µs 46.435µs 124.373µs 554.92% 4.830 33.522 49.05% 0.830µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.243µs; 25.497µs] or [-6.815%; +6.815%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.783ms 6.796ms ± 0.010ms 6.795ms ± 0.004ms 6.799ms 6.807ms 6.827ms 6.874ms 1.17% 4.502 30.021 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.795ms; 6.798ms] or [-0.020%; +0.020%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.305µs 142.439µs ± 1.289µs 142.315µs ± 0.152µs 142.474µs 142.949µs 143.852µs 159.868µs 12.33% 12.472 165.958 0.90% 0.091µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.260µs; 142.617µs] or [-0.125%; +0.125%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 188.885µs 194.297µs ± 0.712µs 194.414µs ± 0.400µs 194.722µs 195.144µs 195.568µs 195.675µs 0.65% -2.527 16.024 0.37% 0.050µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5110508.699op/s 5146816.255op/s ± 19027.682op/s 5143662.844op/s ± 10581.544op/s 5155680.178op/s 5172152.404op/s 5206550.652op/s 5294217.795op/s 2.93% 2.658 17.277 0.37% 1345.460op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.117µs 18.208µs ± 0.049µs 18.207µs ± 0.023µs 18.232µs 18.257µs 18.286µs 18.696µs 2.68% 4.575 45.529 0.27% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53487617.392op/s 54920947.822op/s ± 147460.742op/s 54923512.088op/s ± 69900.934op/s 54975203.993op/s 55162114.780op/s 55182936.525op/s 55197365.369op/s 0.50% -4.363 42.955 0.27% 10427.049op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 11.055µs 11.112µs ± 0.027µs 11.111µs ± 0.019µs 11.131µs 11.151µs 11.176µs 11.200µs 0.80% 0.081 -0.091 0.24% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 89284842.363op/s 89994566.495op/s ± 220337.907op/s 90000393.775op/s ± 150766.882op/s 90143384.322op/s 90398506.279op/s 90430735.440op/s 90459363.958op/s 0.51% -0.067 -0.105 0.24% 15580.243op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [194.199µs; 194.396µs] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5144179.201op/s; 5149453.309op/s] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.201µs; 18.215µs] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54900511.181op/s; 54941384.462op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good execution_time [11.108µs; 11.116µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/good throughput [89964029.780op/s; 90025103.210op/s] or [-0.034%; +0.034%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 273.275ns 284.608ns ± 14.232ns 277.369ns ± 2.688ns 289.020ns 316.848ns 321.943ns 323.289ns 16.56% 1.472 0.832 4.99% 1.006ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [282.635ns; 286.580ns] or [-0.693%; +0.693%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.576µs 38.064µs ± 0.785µs 37.692µs ± 0.060µs 37.847µs 39.716µs 39.773µs 41.002µs 8.78% 1.739 1.326 2.06% 0.056µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.956µs; 38.173µs] or [-0.286%; +0.286%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.408µs 3.269µs ± 1.445µs 3.110µs ± 0.020µs 3.130µs 3.175µs 14.240µs 15.260µs 390.71% 7.617 57.971 44.10% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.069µs; 3.469µs] or [-6.127%; +6.127%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.416ms 58.690ms ± 0.187ms 58.625ms ± 0.082ms 58.754ms 59.057ms 59.267ms 59.554ms 1.58% 1.459 2.185 0.32% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.664ms; 58.716ms] or [-0.044%; +0.044%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.614µs 4.631µs ± 0.006µs 4.630µs ± 0.004µs 4.634µs 4.640µs 4.644µs 4.659µs 0.61% 0.426 1.826 0.13% 0.000µs 1 200
credit_card/is_card_number/ throughput 214650726.995op/s 215959073.997op/s ± 277481.827op/s 215965467.138op/s ± 171733.558op/s 216132375.677op/s 216411961.811op/s 216563139.750op/s 216713855.440op/s 0.35% -0.412 1.780 0.13% 19620.928op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 95.142µs 95.644µs ± 0.406µs 95.586µs ± 0.146µs 95.764µs 96.069µs 96.187µs 100.330µs 4.96% 7.794 87.265 0.42% 0.029µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9967110.434op/s 10455585.348op/s ± 42951.323op/s 10461746.624op/s ± 16005.503op/s 10474761.064op/s 10496061.406op/s 10499485.362op/s 10510564.168op/s 0.47% -7.438 81.798 0.41% 3037.117op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.562µs 86.125µs ± 0.480µs 86.105µs ± 0.221µs 86.285µs 86.678µs 86.856µs 91.223µs 5.94% 6.097 61.848 0.56% 0.034µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10962144.596op/s 11611407.401op/s ± 62659.905op/s 11613698.412op/s ± 29868.907op/s 11646149.615op/s 11681360.385op/s 11686721.787op/s 11687441.934op/s 0.63% -5.668 55.832 0.54% 4430.724op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.616µs 4.631µs ± 0.006µs 4.631µs ± 0.004µs 4.634µs 4.639µs 4.641µs 4.680µs 1.06% 1.983 15.037 0.14% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 213696966.423op/s 215953023.611op/s ± 299967.945op/s 215958568.373op/s ± 180636.228op/s 216129899.474op/s 216394681.199op/s 216594990.790op/s 216632480.189op/s 0.31% -1.929 14.558 0.14% 21210.937op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 82.268µs 82.774µs ± 0.303µs 82.782µs ± 0.216µs 82.915µs 83.302µs 83.574µs 83.962µs 1.43% 0.716 0.485 0.37% 0.021µs 1 200
credit_card/is_card_number/378282246310005 throughput 11910109.971op/s 12081262.132op/s ± 44132.852op/s 12079947.944op/s ± 31465.341op/s 12112696.832op/s 12142278.260op/s 12145396.375op/s 12155436.082op/s 0.62% -0.695 0.422 0.36% 3120.664op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.970µs 59.058µs ± 0.043µs 59.057µs ± 0.022µs 59.079µs 59.120µs 59.155µs 59.358µs 0.51% 2.156 12.261 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16847057.359op/s 16932656.673op/s ± 12398.461op/s 16932854.459op/s ± 6375.323op/s 16938956.659op/s 16949640.756op/s 16953039.558op/s 16957677.030op/s 0.15% -2.135 12.096 0.07% 876.704op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.833µs 6.843µs ± 0.005µs 6.843µs ± 0.002µs 6.845µs 6.850µs 6.854µs 6.888µs 0.66% 4.133 36.682 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145181190.992op/s 146133382.596op/s ± 102262.727op/s 146141857.480op/s ± 39000.137op/s 146176239.052op/s 146270881.407op/s 146317904.727op/s 146355136.445op/s 0.15% -4.088 36.146 0.07% 7231.067op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.618µs 4.630µs ± 0.005µs 4.630µs ± 0.003µs 4.634µs 4.637µs 4.641µs 4.643µs 0.26% 0.014 -0.395 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215394547.467op/s 215970907.478op/s ± 228274.133op/s 215963620.930op/s ± 150698.361op/s 216127104.360op/s 216341403.006op/s 216442498.308op/s 216529088.829op/s 0.26% -0.009 -0.397 0.11% 16141.419op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 75.230µs 75.442µs ± 0.083µs 75.448µs ± 0.055µs 75.497µs 75.577µs 75.645µs 75.655µs 0.27% 0.021 -0.014 0.11% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13217836.606op/s 13255218.760op/s ± 14513.325op/s 13254175.676op/s ± 9645.457op/s 13264500.880op/s 13280671.975op/s 13287244.473op/s 13292518.970op/s 0.29% -0.015 -0.015 0.11% 1026.247op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.899µs 66.121µs ± 0.105µs 66.120µs ± 0.064µs 66.178µs 66.304µs 66.422µs 66.566µs 0.67% 0.890 1.983 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15022670.891op/s 15123755.389op/s ± 23991.860op/s 15123953.736op/s ± 14711.179op/s 15139840.339op/s 15157556.872op/s 15166298.261op/s 15174738.613op/s 0.34% -0.875 1.932 0.16% 1696.481op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.614µs 4.629µs ± 0.006µs 4.629µs ± 0.004µs 4.633µs 4.638µs 4.645µs 4.648µs 0.39% 0.107 0.362 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215165352.083op/s 216009850.542op/s ± 259922.634op/s 216007873.502op/s ± 167780.025op/s 216180007.934op/s 216411717.927op/s 216638623.390op/s 216724662.253op/s 0.33% -0.099 0.357 0.12% 18379.306op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.373µs 62.757µs ± 0.201µs 62.767µs ± 0.155µs 62.903µs 63.110µs 63.144µs 63.300µs 0.85% 0.211 -0.682 0.32% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15797731.803op/s 15934755.303op/s ± 51025.734op/s 15931916.410op/s ± 39371.960op/s 15977443.066op/s 16014063.934op/s 16025123.897op/s 16032565.266op/s 0.63% -0.198 -0.694 0.32% 3608.064op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.977µs 59.066µs ± 0.039µs 59.064µs ± 0.019µs 59.084µs 59.135µs 59.164µs 59.228µs 0.28% 0.695 1.936 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16884016.934op/s 16930223.310op/s ± 11193.070op/s 16930916.781op/s ± 5306.487op/s 16935695.165op/s 16947287.165op/s 16954599.939op/s 16955858.813op/s 0.15% -0.688 1.918 0.07% 791.470op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.833µs 6.843µs ± 0.003µs 6.842µs ± 0.002µs 6.845µs 6.848µs 6.851µs 6.854µs 0.17% 0.015 0.690 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145905766.431op/s 146142511.387op/s ± 73946.679op/s 146149373.857op/s ± 40794.854op/s 146178314.453op/s 146270550.713op/s 146333665.854op/s 146349305.562op/s 0.14% -0.011 0.689 0.05% 5228.820op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.630µs; 4.631µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ throughput [215920617.684op/s; 215997530.310op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [95.588µs; 95.701µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10449632.708op/s; 10461537.989op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [86.058µs; 86.191µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11602723.341op/s; 11620091.461op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/37828224631 execution_time [4.630µs; 4.632µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631 throughput [215911450.939op/s; 215994596.283op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/378282246310005 execution_time [82.732µs; 82.816µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/378282246310005 throughput [12075145.743op/s; 12087378.521op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.052µs; 59.064µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16930938.365op/s; 16934374.980op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.842µs; 6.844µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [146119209.965op/s; 146147555.226op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.630µs; 4.631µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [215939270.879op/s; 216002544.078op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [75.431µs; 75.454µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13253207.352op/s; 13257230.167op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.107µs; 66.136µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15120430.348op/s; 15127080.430op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.629µs; 4.630µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215973827.764op/s; 216045873.319op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.729µs; 62.784µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15927683.627op/s; 15941826.979op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.061µs; 59.071µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16928672.058op/s; 16931774.562op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146132263.088op/s; 146152759.685op/s] or [-0.007%; +0.007%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.246µs 72.547µs ± 0.206µs 72.528µs ± 0.072µs 72.588µs 72.747µs 73.583µs 74.378µs 2.55% 5.150 37.530 0.28% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.518µs; 72.575µs] or [-0.039%; +0.039%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 625.692µs 627.143µs ± 0.934µs 627.052µs ± 0.327µs 627.356µs 627.927µs 633.183µs 634.387µs 1.17% 5.117 34.062 0.15% 0.066µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1576323.797op/s 1594535.068op/s ± 2356.929op/s 1594763.889op/s ± 832.372op/s 1595679.129op/s 1596791.535op/s 1597382.489op/s 1598229.162op/s 0.22% -5.073 33.651 0.15% 166.660op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 463.086µs 464.015µs ± 0.472µs 463.984µs ± 0.211µs 464.186µs 464.597µs 466.299µs 467.242µs 0.70% 2.737 14.827 0.10% 0.033µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2140217.595op/s 2155106.375op/s ± 2187.741op/s 2155248.077op/s ± 979.181op/s 2156288.163op/s 2157929.894op/s 2159161.097op/s 2159425.620op/s 0.19% -2.709 14.617 0.10% 154.697op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.189µs 179.825µs ± 0.353µs 179.815µs ± 0.266µs 180.057µs 180.374µs 180.796µs 181.255µs 0.80% 0.580 0.733 0.20% 0.025µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5517097.350op/s 5560991.436op/s ± 10899.932op/s 5561258.106op/s ± 8222.304op/s 5571063.002op/s 5576105.772op/s 5578275.855op/s 5580689.833op/s 0.35% -0.566 0.687 0.20% 770.742op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.313µs 47.463µs ± 0.052µs 47.459µs ± 0.033µs 47.496µs 47.549µs 47.587µs 47.597µs 0.29% 0.090 0.049 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21009721.153op/s 21069030.909op/s ± 23256.652op/s 21070769.517op/s ± 14712.840op/s 21083167.446op/s 21102335.456op/s 21125845.327op/s 21135910.749op/s 0.31% -0.084 0.051 0.11% 1644.494op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.739µs 49.897µs ± 0.076µs 49.887µs ± 0.048µs 49.943µs 50.033µs 50.088µs 50.142µs 0.51% 0.556 -0.060 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19943283.137op/s 20041290.910op/s ± 30670.967op/s 20045228.489op/s ± 19162.061op/s 20063314.748op/s 20086388.328op/s 20098233.188op/s 20104785.216op/s 0.30% -0.549 -0.071 0.15% 2168.765op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [627.014µs; 627.273µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1594208.421op/s; 1594861.716op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [463.949µs; 464.080µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2154803.175op/s; 2155409.574op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [179.776µs; 179.874µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5559480.810op/s; 5562502.062op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.456µs; 47.470µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21065807.760op/s; 21072254.057op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.887µs; 49.908µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20037040.208op/s; 20045541.611op/s] or [-0.021%; +0.021%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz bc4ab43 1734026717 jordan.gonzalez/trace-mini-agent/use-tracing-crate-for-logging
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.664µs 2.721µs ± 0.017µs 2.720µs ± 0.007µs 2.730µs 2.749µs 2.755µs 2.769µs 1.82% -0.792 2.284 0.62% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.718µs; 2.723µs] or [-0.086%; +0.086%] None None None

Baseline

Omitted due to size.

@duncanista duncanista changed the title chore(trace-mini-agent): change logging crate [trace-mini-agent] change logging crate Dec 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.92%. Comparing base (373b778) to head (bc4ab43).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   70.95%   70.92%   -0.04%     
==========================================
  Files         313      313              
  Lines       45747    45747              
==========================================
- Hits        32458    32444      -14     
- Misses      13289    13303      +14
Components Coverage Δ
crashtracker 38.27% <ø> (ø)
crashtracker-ffi 5.71% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.06% <ø> (ø)
data-pipeline-ffi 90.54% <ø> (ø)
ddcommon 82.31% <ø> (ø)
ddcommon-ffi 65.52% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (ø)
profiling 84.31% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.56% <ø> (ø)
sidecar-ffi 1.18% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.52% <ø> (ø)

duncanpharvey
duncanpharvey approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@duncanpharvey duncanpharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanpharvey duncanpharvey duncanpharvey approved these changes

Assignees
No one assigned
Labels
mini-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanista @codecov-commenter @duncanpharvey