Added cache interface and cachelib + noop implementations #1209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This breaks out just the cache interface from #1180 and leaves out any use of the dependency injection anywhere. I've also added a
NoOpCache
implementation of theCacheInterface
which makes it nicer to use the dependency while also keeping it optional (ANoOpCache
has the same methods so no need to do a null check for the cache everywhere).I also added the caching docs page that describes how this works and how someone can implement their own custom cache dependency.
Test Plan
Wrote some tests to get full coverage.
make check
passesmake test
shows 100% unit test coverageDeployment Plan
Deploying this has no effect because it's not used anywhere yet.