-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Linting of the repo #15
Conversation
dc41f5d
to
14c5519
Compare
Using |
Doctsrings have been added to all the classes and existing functions. Restructuring the code may require updating these docstrings accordingly in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seem sensible so far - mostly formatting changes.
The docstrings are somewhat hybrid at the moment, but we should make sure they conform to the numpy style: https://numpydoc.readthedocs.io/en/latest/format.html
Main one I can spot at the moment is args
should be Parameters
.
To merge after addition of CI and once Jacks final comments is addressed (internally). Open a new issue on Docstrings so that these can be updated with a bit more detail after #5. |
Not changing this at the moment as the ML code is being refactored. Once that is done, I will update the docstrings acc to the numpy format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #4
The PR is to lint the entire repo to improve the quality of the code. Things formatted are in the form of:
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks