Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed polyfills #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ELFoglalt
Copy link

Fixes #14. Removes polyfills for reasons detailed in the issue.

@David-Desmaisons
Copy link
Owner

Thanks for the PR.
Could you please add the corresponding explanation and link to pollyfill in the README?

@ELFoglalt
Copy link
Author

Added an extra paragraph after the installation section.

Considering this may be a breaking change in some browsers, I assume a version number bump would also be required?

@David-Desmaisons
Copy link
Owner

David-Desmaisons commented Mar 23, 2020

Considering this may be a breaking change in some browsers, I assume a version number bump would also be required?

Correct

@ELFoglalt
Copy link
Author

ELFoglalt commented Mar 23, 2020

Hmm... Following semver this would have to be 1.2.0->2.0.0 then? Kind of a big jump for such a small change. But technically we are no longer compatible with ^1.x.x and possibly break things, right?

@David-Desmaisons
Copy link
Owner

Excatly

- 3bc876b is considered a breaking change, version should reflect that
- Updated build no longer includes polyfills
@ELFoglalt
Copy link
Author

Done, and re-built so that the dist folder is also up to date with the changes.

@ELFoglalt ELFoglalt mentioned this pull request Mar 23, 2020
@jja-financial-com
Copy link

Is there any updates for this? Our app is still in Vue 2.X and apparently using require breaks tree shaking in webpack
Is there any plans to merge this and create a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove find polyfill?
3 participants