Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Lead functions #99

Closed
GuerrillaCoder opened this issue Dec 2, 2021 · 1 comment
Closed

Missing Lead functions #99

GuerrillaCoder opened this issue Dec 2, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@GuerrillaCoder
Copy link

I just added in the missing Lead create function in my fork and there are some weird issues. The PD lead endpoint follows the same format as the deal endpoint but there are some differences.

Deal endpoint allows null properties, leads does not.
Deal endpoint accepts visibility as an integar, leads accepts it as a string
Deal endpoint receives value as a double, leads receives it as an object

This means if you use the same pattern as every other endpoint then it doesn't actually work because it needs to be serialized differently.

I am going to do a quick hack to make it work in my code but posting this to save anyone else time who decides to try to add those endpoints

@DavidRouyer
Copy link
Owner

Duplicate of #56

@DavidRouyer DavidRouyer marked this as a duplicate of #56 Oct 11, 2022
@DavidRouyer DavidRouyer added the enhancement New feature or request label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants