Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle password not working? #62

Open
yringler opened this issue Nov 22, 2022 · 2 comments
Open

Toggle password not working? #62

yringler opened this issue Nov 22, 2022 · 2 comments

Comments

@yringler
Copy link

This must be on me, but I don't see what I might be doing wrong.
I did the "homework" for module 4, and the password wasn't becoming visible.
Then I tried the original version - also not.
Did something change in browser security recently? Checked firefox and chrome.
I'm probably going to find tomorrow that I made a silly mistake, IDK.

@yringler
Copy link
Author

So - despite the words "Mask USER NAME" being clearly in the UI, it never occurred to me that there would be an option to mask anything other than a password 😆
Would you take a PR to have the toggle work on the password field?

@DeborahK
Copy link
Owner

Glad you resolved the issue!

At this time, we want the code here to match what's covered in the course, so we aren't taking PRs.

We do update the course from time to time and will include your feedback.

Thanks for posting your resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants