Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add access to popup properties from DropdownMenu #31

Open
berrehailb opened this issue Jul 22, 2022 · 4 comments
Open

feat: add access to popup properties from DropdownMenu #31

berrehailb opened this issue Jul 22, 2022 · 4 comments
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request help wanted ✋ Extra attention is needed

Comments

@berrehailb
Copy link

Is your feature request related to a problem? Please describe.
I was needing to have the same functionality that AutoCompleteTextView but using Vitamin Compose. But I can't access to PopupProperties because it's not targetable using VitaminMenus.Dropdown.

Modify the PopupProperties will enables me to change the default properties from focusable to not focusable in order to continue to type text even if dropdown is appearing.

Describe the solution you'd like
I would like to have the possibility to define my own PopupProperties from VitaminMenus.Dropdown.
@berrehailb berrehailb added the enhancement 🚀 New feature or request label Jul 22, 2022
@GerardPaligot
Copy link
Contributor

We have a text input component with a dropdown docked (VitaminTextInputs. OutlinedDropdown(...) (doc) and VitaminTextInputs.FilledDropdown (doc)) but I think this component doesn't fit your need too because the text input isn't editable (according to the design specification).

We should be able to improve this last component to fit your needs but we need to improve first the design specification of the component if the design system team is okay with that. ping @SimonLeclercq @Sabrinavigil @MARIEDELATTRE

@lauthieb lauthieb changed the title Add acccess to popup properties from DropdownMenu feat: add access to popup properties from DropdownMenu Oct 19, 2022
@lauthieb lauthieb moved this to 🆕 New in Decathlon Design System Dec 19, 2022
@lauthieb lauthieb moved this from 🆕 New to 👀 Dev review in Decathlon Design System Dec 19, 2022
@lauthieb lauthieb moved this from 👀 Dev review to 🔖 Dev to do in Decathlon Design System Jan 9, 2023
@ManonPolle ManonPolle moved this from 🔖 Dev to do to 📋 Backlog in Decathlon Design System Jan 17, 2023
@ManonPolle
Copy link
Contributor

@MARIEDELATTRE @Sabrinavigil @SimonLeclercq lets talk about it in grooming session

@lauthieb
Copy link
Member

Validated in grooming session by @Decathlon/design-system-core-team-design

@lauthieb lauthieb moved this from 📋 Backlog to 🔖 Dev to do in Decathlon Design System Jan 19, 2023
@lauthieb
Copy link
Member

@ManonPolle to create on vitamin-android repo too

@ManonPolle ManonPolle removed their assignment Jan 31, 2023
@lauthieb lauthieb added the community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community label Mar 24, 2023
@lauthieb lauthieb removed the run 💨 label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community 👥 As we stopped improvements for this version ofVitamin, this issue needs to be done by the community enhancement 🚀 New feature or request help wanted ✋ Extra attention is needed
Projects
Decathlon Design System
Status: 🔖 Dev to do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GerardPaligot @lauthieb @ManonPolle @berrehailb