Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background image of the website is not related #1

Closed
DeepNinja07x opened this issue Sep 29, 2021 · 7 comments · Fixed by #8
Closed

Background image of the website is not related #1

DeepNinja07x opened this issue Sep 29, 2021 · 7 comments · Fixed by #8
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@DeepNinja07x
Copy link
Owner

Sometimes, based on the city, the background image shown is not related with the city. The image is requested from Unsplash API.

@DeepNinja07x DeepNinja07x added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Sep 29, 2021
@tnmyk
Copy link

tnmyk commented Sep 30, 2021

I would like to work on this!

@DeepNinja07x
Copy link
Owner Author

sure

@DeepNinja07x
Copy link
Owner Author

start from tomorrow

@tnmyk
Copy link

tnmyk commented Sep 30, 2021

I think there is no other option than change the api from unsplash to some other... I have tried making the query name to lowercase which is improving the images but still some of them are not related

@DeepNinja07x
Copy link
Owner Author

It's better than noting. You can also try it by changing the API. If it works perfectly, I'll merge it; otherwise just change the query name as you've mentioned. I'll merge that too

@DeepNinja07x DeepNinja07x pinned this issue Sep 30, 2021
@lara-sahoo
Copy link

Hi @DeepNinja07x I looked after this issue and found 3 things:-

  1. Using Google Places API. Article on it: - https://codeburst.io/adding-city-images-to-your-react-app-14c937df2db2
  2. Using Teleport API. http://developers.teleport.org/api/getting_started/
  3. Using unsplash API https://unsplash.com/developers

Have a look at this and let me know which one would you prefer. I would like to work on this.

@jblancoh
Copy link
Contributor

jblancoh commented Oct 5, 2021

I made you a PR with the google place API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants