Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added flag to save json log file and improved trajectory preparation #21

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

gwirn
Copy link
Collaborator

@gwirn gwirn commented Jun 26, 2024

  • Moves the imaging (applying periodic boundary conditions) in front of saving the new topology. Furthermore, if imaging fails it tries a fallback solution by supplying an anchor molecule. Additionally it aligns all frames to the first frame of the trajectory.
  • Adds a flag to the Trainer class to be able to save the unformatted json strings to a log file.

@gwirn gwirn requested a review from degiacom June 26, 2024 09:16
Copy link
Member

@degiacom degiacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@degiacom degiacom merged commit 6754592 into master Jun 27, 2024
3 checks passed
@degiacom degiacom deleted the prepare_fix branch June 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants