Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two update_max_potential_damage functions #367

Open
2 of 5 tasks
Santonia27 opened this issue Jul 29, 2024 · 0 comments
Open
2 of 5 tasks

Two update_max_potential_damage functions #367

Santonia27 opened this issue Jul 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Santonia27
Copy link
Collaborator

hydomt_fiat version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of hydomt_fiat.

Reproducible Example

When updating the pot. damages in the MB GUI, one functions is used and when running floodadapt or the test test_update_max_potential_damage in hydromt the oher functions is used.

Current behaviour

There are 2 functions for update_max_potential_damage. The one called by the MB GUI is in fiat.py and the one called in floodadapt in the exposure_vector.

Desired behaviour

only have one function

Task list

  • investigate the reason for 2 different functions
  • investigate where which function is used in detail
  • merge both functions to one and only use one

Additional context

No response

@Santonia27 Santonia27 added the bug Something isn't working label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants