object indexing

[panosatha]

hydomt_fiat version checks

• I have checked that this issue has not already been reported.
• I have checked that this bug exists on the latest version of hydomt_fiat.

Reproducible Example

It seems that for some of the methods with respect to applying changes (elevating, changing max damage etc.) the indexing was not implemented in a safe way, assuming that always exposure objects are in asceding order based on Object ID. Or reordering the objects.

Some of these parts were corrected in #365, but it is better to a general check of all these methods again to ensure that they are implemented correcty.

Current behaviour

Check above

Desired behaviour

Safe way of indexing FIAT objects.
The object ID should be always used for indexing since it is the unique identifier

Task list

• go through all the methods using indexing and check implementation
• apply general object base indexing and not a different approach in every method ( the object ID should be always used for indexing since it is the unique identifier)

Additional context

No response

[Santonia27]

Can you please list which methods are used in Floodadapt;

• Elevate homes = raise_ground_floor_height

  in def set_height_relative_to_reference - the Object ID is set to index already. Not sure if there is modification neccessary
  same in def raise_ground_floor_height line 1116, exposure_db index set to Object ID already

• (Check update classification in MB GUI)

Anything else? Check in FIAT Adapter in Floodadapt

Object ID Indexing right at the beginning from the exposure df and geoms and then should be the same at all times.

Actions:

• Create an inventory on where the indexing goes wrong/may go wrong

[Santonia27]

Here a little inventory of the functions in floodadapt and if they need indexing or not. Maybe also worth a discussion per function..

inventory.docx