Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New composite areas that are divided per aggregation areas dont have individual values for Ground Floor Height And Ground Floor Elevation #399

Open
2 of 4 tasks
panosatha opened this issue Oct 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@panosatha
Copy link
Collaborator

hydomt_fiat version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of hydomt_fiat.

Reproducible Example

When using new composite areas that need to be divided to fall in different aggregation areas, the resulting splitted polygons have the values for ground elevation and ground floor height of the original polygons extents.

Current behaviour

When using new composite areas that need to be divided to fall in different aggregation areas, the resulting splitted polygons have the values for ground elevation and ground floor height of the original polygons extents and not the splitted ones:

The split part takes place here:

new_objects, aggregated_objects_geoms, _ = join_exposure_aggregation_areas(
_new_exposure_geoms.merge(new_objects, on="Object ID"),
aggregation_area_fn=aggregation_area_fn,
attribute_names=attribute_names,
label_names=label_names,
new_composite_area=True,
)

Desired behaviour

The splitted polygons should have their individual ground elevation and ground floor height be calculated. This means that this part should be moved earlier in the code:

new_objects, aggregated_objects_geoms, _ = join_exposure_aggregation_areas(
_new_exposure_geoms.merge(new_objects, on="Object ID"),
aggregation_area_fn=aggregation_area_fn,
attribute_names=attribute_names,
label_names=label_names,
new_composite_area=True,
)

Task list

  • Update code
  • Test use

Additional context

No response

@panosatha panosatha added the bug Something isn't working label Oct 16, 2024
@panosatha panosatha self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant