Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for HPA configuration #184

Open
zprebosnyak-lm opened this issue Nov 19, 2024 · 0 comments
Open

Allow for HPA configuration #184

zprebosnyak-lm opened this issue Nov 19, 2024 · 0 comments

Comments

@zprebosnyak-lm
Copy link
Contributor

To allow the pods to utilize horizontal pod auto scaling the replicas and strategy.type fields of the deployment manifests need to be optionally turned on/off.

Propose modifying the deployment templates like so:

  {{- if .Values.notificationPublisher.replicas.enabled }}
  replicas: {{ .Values.notificationPublisher.replicas.replicaCount }}
  {{- end }}
  {{- if .Values.notificationPublisher.deployment.strategy.enabled }}
  strategy:
    type: {{ .Values.notificationPublisher.deployment.strategy.type }}
  {{- end }}

values.yaml

  replicas:
    enabled: true
    replicaCount: 1
  deployment:
    # -- The deployment strategy to use.
    strategy:
      enabled: true
      type: RollingUpdate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant