Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sky is the limit #23

Open
6 tasks done
DerKarlos opened this issue Nov 25, 2023 · 4 comments
Open
6 tasks done

The sky is the limit #23

DerKarlos opened this issue Nov 25, 2023 · 4 comments

Comments

@DerKarlos
Copy link
Owner

DerKarlos commented Nov 25, 2023

  • Time after time tiles, visible in the frustum, should get loaded until "the sky"; the Skybox.
  • (While I really would prefer a sphere / a sky dome.)
  • This way, the distance to the sky is related to the GPU load. Slow user devices man need less distance.
  • Seeing Buildings get visible "out of the sky" looks really odd!
    Fog would be better, but I only know fog at a linear line far away.
  • Of course the sky needs to be relative to the camera.
  • Some more distance behind the sky, in any direction, tiles may get removed to avoid memory overload.
@oli-obk
Copy link
Collaborator

oli-obk commented Nov 25, 2023

We're using fog already, but it's very subtle. We need to tune it up when the sky is smaller

@DerKarlos
Copy link
Owner Author

It woks, but ...
On my Mac Air, the app runs with 5 to 10 FPS. The internal GPU is not that good. We will have some user with week mobiles a the same problem.

  • 0.1 % Reaction was to slow, I used 1%
  • 10km Sky default size is to much, the tiles start close, so there is time to "grow" to 10km. I set it to 2000m.
  • 1000m minimum is ok, less is stupid. But the fog is to strong for 1000m. Could we set it to less thickness? May be dynamically according to the Sky size.
    Are my values ok for the experience on your device?

@DerKarlos DerKarlos reopened this Nov 27, 2023
@oli-obk
Copy link
Collaborator

oli-obk commented Nov 27, 2023

May be dynamically according to the Sky size.

that's already happening. we can tune the parameters though. There are also other fog systems we can try out

@DerKarlos
Copy link
Owner Author

Some tests. visibility: sky.scale.x *
1.0 nice fading but dusty in the front
2.0 to less fading not dusty in the front
1.5. seems a not so good compromise
I am not sure if visibility is the "thickness".
Could the fog start may be 90% before the sky and go to 100% at the sky?

We need to take some time to experiment with the parameters.
We could add test parameter and led our user find the solution ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants