-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization cleanup #511
Open
winterheart
wants to merge
61
commits into
DescentDevelopers:main
Choose a base branch
from
winterheart:localization-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Localization cleanup #511
winterheart
wants to merge
61
commits into
DescentDevelopers:main
from
winterheart:localization-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterheart
force-pushed
the
localization-update
branch
3 times, most recently
from
August 3, 2024 18:04
eef4e92
to
93d7729
Compare
winterheart
force-pushed
the
localization-update
branch
2 times, most recently
from
August 11, 2024 02:12
01bdfcd
to
b0c0ab9
Compare
There some additional changes to OSIRIS checksum generation. I'm still planning to rewrite save/load functions with platform independent serialization, but some features of these are required right now. Added |
winterheart
force-pushed
the
localization-update
branch
2 times, most recently
from
August 22, 2024 10:25
f90d53c
to
a6a897b
Compare
winterheart
force-pushed
the
localization-update
branch
from
September 3, 2024 09:05
a6a897b
to
1c25c9a
Compare
pzychotic
reviewed
Sep 7, 2024
pzychotic
reviewed
Sep 7, 2024
winterheart
force-pushed
the
localization-update
branch
2 times, most recently
from
September 12, 2024 12:09
aa3bc27
to
153a09c
Compare
winterheart
force-pushed
the
localization-update
branch
3 times, most recently
from
September 18, 2024 18:21
674118b
to
4efea68
Compare
called once guard prevents to re-load messages for different language in case if language is changed on runtime.
winterheart
force-pushed
the
localization-update
branch
from
September 23, 2024 22:35
4efea68
to
72fbff9
Compare
Simplify memory management and string concatenation.
Refactored code, reworked loading localized files.
Export *MessageMap via Osiris import interfaces.
Uppercase language suffix (for German), use same naming as script filename for all messages.
This field intended to solve problem when CHECKSUM is different on various platforms and environments due variadic size of structs. Unfortunately, this approach cannot be applied for all structs used in checksum calculation since part of them are poorly serialized/deserialized by fread() / fwrite() functions.
Rename function since GetMessage() is part of WinAPI.
Assuming that index will never be negative, change it to unsigned int.
winterheart
force-pushed
the
localization-update
branch
from
September 23, 2024 22:58
72fbff9
to
37e163a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Currently there in project two kinds of localization files: STR (where all messages of all languages assembled into one file; used in core engine) and MSG (where messages split by language). This PR overhauls localization both frameworks.
Both frameworks now exports their functions to DLL API, so CHECKSUM is changed. OSIRIS scripts has huge internal changes, which may make them incompatible with legacy editor script generator.
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments