-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Whiteboard font scaleable #176
Comments
Hi @TadeSF. I would like to work on this issue |
Great! Go ahead! Thank you :) |
Hi @TadeSF. |
Ofcourse! You won't actually get an email in dev mode, but there should be a smtp-mock running in the background on port 3777. When you open that in the browser, the email should appear and you can click on the link. Next, you won't have any conferences there. To create a mock conference, you can just run two seeding scripts within the backend container, located at prisma/seed.ts (you can also just run bunx prisma reset, which should run this seeding script automatically) and prisma/custom_seeds/seed_simsim.ts (which is a seeding script for practise conferences for our chairs, simsim stands for simulation of the simulation). Last step: You need to assign your account as a conference admin: Go into prisma studio at port 5555 in your browser and create a new ConferenceMember of Role Admin with your account and the seeded conference as foreign keys. That step should be fairly simple. After all that, you should be able to refresh and see the conference to launch. And then you have access to all parts of the app. |
If you need any more assistance, I am happy to help. And sorry that this whole process is not documented well, we didn't have any contributors to this part of the app, so there was no urgent need for better guidance. If you get stuck, i can also offer you to video call, so that i can get you started with the environment stuff. Just let me know :) |
Hey @ahsanfarooq210! Perfect, I am glad you managed to navigate through my unprecise explanaitions to get this far. To answer your question: When the State of Debate is "Formal Debate", the Whitboard is hidden from the presentation mode, since the speakers list and comment list are more important. Please just change the "Status Timer" on the Configurations Screen for example to "informal caucus" or "pause". The whiteboard should then appear. Also, I notice because of the missing Font Awesome Pro Icons, you can't really use the navbar (which is really not good - especially for devs like you), I should file an issue for that). Therefore you might have to navigate through changing the url. You can access the whiteboard screen by replacing the "/overview" (? I think its "/overview") at the end with "/whiteboard". You should then see an editor for the whiteboard before you :) |
Hey @ahsanfarooq210, thanks! Did you also add any functionality for users/chairs to change the font size dynamically or is it now just statically set to 18px? |
And just on a side note: Have have you any Idea why the Font is not loaded correctly? Next.js should fetch the fonts from Google Fonts and I am wondering why that is not working in your environment... |
Hi @TadeSF. |
Hi @TadeSF. What is the UI/UX of how we are going to allow the user to change the text size of the whiteboard if that is the approach we are going to follow? |
Hey @ahsanfarooq210! We have implemented a similar scaling approach on the presentation screen in the bottom right corner. It is mainly implemented here: const [remSize, setRemSize] = useState<number>(16);
...
useEffect(() => {
document.documentElement.style.fontSize = `${remSize}px`;
localStorage.setItem("presentationRem", remSize.toString());
}, [remSize]); That is basically what I had in mind for the change of text size. You can either try to bind the whiteboard size to the presentation mode rem size, but I actually would prefer it having its own buttons (for example in the header on the right side), so that it can be changed in any viewing context – not only in presentation mode). Does that make it clearer what I was aiming for? |
Another thing regarding FontAwesome: Could you please try something for me regarding fontawesome? Here are the free fontawesome files to download: https://files.dmun.de/s/QwNjAwM Once downloaded, please add the contents to your source code like the following. You have to override the files that are (in encrypted state) already there. Just be sure not to commit the changes.
Once you've done that, you should be seeing some icons and some placeholders for icons that are not in the Free Pack. But in theory, this should make it more easy to navigate the app and actually enable you to fidget with icons yourself. |
And about the Fonts: That is really weird, since the fonts are not hardcoded anywhere but rather referenced as google fonts from google directly. Could you please go into your Network Console Tool in the browser and look for any fonts not being loaded and if so, could you report the status code back to me please? |
Hey @ahsanfarooq210! |
I am very busy right now, so please be a little patient with me testing and code reviewing your PR. Sorry for keeping you waiting. |
Hi @TadeSF. I have removed the "Font size text". changes have been pushed in the PR |
hi @TadeSF. I have reverted the documentation of the whiteboard component. That was the only feedback on the PR so far. |
Hi @TadeSF. I have figured out why the font size was not changing. Some of my commitments are not being pushed in this branch. when I check out on them, git gives me an error. so I made those changes in a new commit and pushed the code. Can you please test it again? |
hi @Strehk. Please review the changes in the PR, I have fixed the bug. |
The Whiteboard font is especially in the presentation mode very small. It should be adjustable or just made bigger by default.
The text was updated successfully, but these errors were encountered: