Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better flag integration with Flagpack #86

Open
Strehk opened this issue Mar 4, 2024 · 5 comments
Open

Better flag integration with Flagpack #86

Strehk opened this issue Mar 4, 2024 · 5 comments
Assignees
@Strehk
Labels
enhancement Enhancement of existing features
Milestone
MUN-SH 2025

Comments

@Strehk
Copy link
Member

Strehk commented Mar 4, 2024

We should outsource flags by using a library. This looks very promising: https://github.com/Yummygum/flagpack-core
@Strehk Strehk added bug Something isn't working enhancement Enhancement of existing features frontend and removed bug Something isn't working labels Mar 4, 2024
@Strehk
Copy link
Member Author

Strehk commented Mar 19, 2024

Flagpack is not suitable, since the flags are too small. Otherwise, this Libaray is promising, but lacks alpha-3 Code compatibility. Therefore: Closed for now.

@Strehk Strehk closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@m1212e
Copy link
Member

m1212e commented Mar 19, 2024 •
edited
Loading

@TheXires Just so you know and don't ask yourself where the issue you wanted to work on went :D

@Strehk
Copy link
Member Author

Strehk commented Mar 19, 2024

Oh so sorry! Feel free to reopen!!

@m1212e
Copy link
Member

m1212e commented Mar 20, 2024

Na its alright :D

@Strehk
Copy link
Member Author

Strehk commented May 28, 2024

use https://github.com/lipis/flag-icons

@Strehk Strehk reopened this May 28, 2024
@Strehk Strehk self-assigned this May 28, 2024
@Strehk Strehk added this to the MUN-SH 2025 milestone May 28, 2024
@Strehk Strehk removed the app: chase label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Strehk Strehk

Labels
enhancement Enhancement of existing features
Projects
None yet
Milestone
MUN-SH 2025
Development

When branches are created from issues, their pull requests are automatically linked.

86-better-flag-integration-with-flagpack DeutscheModelUnitedNations/munify-chase
2 participants
@m1212e @Strehk