Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase / Gift Subscription Drops are not ignored #544

Closed
FlamingFox911 opened this issue Aug 18, 2024 · 6 comments
Closed

Purchase / Gift Subscription Drops are not ignored #544

FlamingFox911 opened this issue Aug 18, 2024 · 6 comments
Labels
Enhancement New feature or request Help / Issue General or specific issues that just require some additional assistance to solve Solved This issue has been resolved

Comments

@FlamingFox911
Copy link

It seems like there is a new drop type. It requires users to Subscribe or Give a Sub, instead of watching participating channels for a certain amount of time.

image

The miner correctly doesn't mine this (since it's flagged as 0 minutes), but it still appears in the inventory list.

image

@DevilXD
Copy link
Owner

DevilXD commented Aug 19, 2024

Hello,

The inventory view isn't supposed to ignore any drops - if a drop appears on the Inventory or Campaigns Twitch pages, then it's going to show up in the inventory view. Drops that have a watching requirement of 0 minutes aren't considered valid mining targets, so the miner just ignores them. Everything works as intended.

What issue are you experiencing, exactly?

@DevilXD DevilXD added the Bug Something isn't working label Aug 19, 2024
@FlamingFox911
Copy link
Author

FlamingFox911 commented Aug 19, 2024

Hmm, besides that, there are no other issues. I was under the assumption that the miner was trying to get a drop for which it has no chance (due to a non-watching requirement), but as you confirmed the miner ignores mining it. But it is still a little annoying that I still see the campaign.

Is there a chance to have a toggle to show or hide 0 minute campaigns?

@DevilXD
Copy link
Owner

DevilXD commented Aug 24, 2024

Hmm, an extra toggle might not be a bad idea, but I can also just make it so that if the sub-based drops is all the campaign contains, then it won't show in the inventory view. There would need to be at least one time-based drop for a campaign to be displayed. Is that enough for you?

@FlamingFox911
Copy link
Author

That can work. Thanks. I'd appreciate it.

Just thought of this, but as an alternative, would it be possible to give the user an option to ignore a campaign? That way, it can also allow users to disregard specific campaigns, regardless of circumstances.

@DevilXD
Copy link
Owner

DevilXD commented Aug 26, 2024

A feature like that is already tracked by #170.

I'll implement the suggestion from my previous comment soon, once I can find some time for it.

@DevilXD
Copy link
Owner

DevilXD commented Sep 11, 2024

Per ab37b0a, campaigns that consist of only sub-based drops (with a total time remaining of 0 minutes, so no timed drops are present) are now excluded from the in-app inventory view.

@DevilXD DevilXD closed this as completed Sep 11, 2024
@DevilXD DevilXD added Help / Issue General or specific issues that just require some additional assistance to solve Solved This issue has been resolved Enhancement New feature or request and removed Bug Something isn't working labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Help / Issue General or specific issues that just require some additional assistance to solve Solved This issue has been resolved
Projects
None yet
Development

No branches or pull requests

2 participants