Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live photo upload system #5

Closed
Rushi98 opened this issue Apr 23, 2018 · 16 comments
Closed

live photo upload system #5

Rushi98 opened this issue Apr 23, 2018 · 16 comments
Assignees
Labels
approved This issue has been approved by maintainers. Grab them before others. discussion Now is a good time to discuss about this feature. Hop in! feature New feature to be added

Comments

@Rushi98
Copy link
Member

Rushi98 commented Apr 23, 2018

  1. upload pics during the event itself
  2. captions
  3. liking the photos to that events activity
@Rushi98 Rushi98 added feature New feature to be added on hold This issue depends on other issues labels Apr 23, 2018
@Rushi98 Rushi98 added the discussion Now is a good time to discuss about this feature. Hop in! label May 9, 2018
@aayushsingla
Copy link
Member

are we going to do this? if yes, can i take this up?

@Rushi98
Copy link
Member Author

Rushi98 commented May 18, 2018

There are some details we need to finalize:

  1. how to upload the pics? firebase cloud storage, user's google drive or something else?
  2. will this feature be linked to other features, and details if so.
  3. database structure for this?

After these (and more if need arises) are resolved, you can take it up.

@aayushsingla
Copy link
Member

Any suggestion from your side for storing pics?
@Rushi98

@Rushi98
Copy link
Member Author

Rushi98 commented May 22, 2018

You can start with any of the two you are comfortable with. Try to keep the code for upload etc. modular so that if there is some issue (ex. we hit 5 GB limit of cloud storage) we are able to swap one for another easily.

@aayushsingla
Copy link
Member

I was thinking to use Flickr API. i think it is cool for all our needs.
https://www.flickr.com/services/api/

@Rushi98
Copy link
Member Author

Rushi98 commented May 22, 2018

We can't. Flickr guidelines specifically ask not to use their service as replacement for content server and we should respect that.

https://www.flickr.com/help/guidelines

@aayushsingla
Copy link
Member

So,if we cant use their API then i will use google drive REST API for it. In database we will use a separate node to store urls for photo and the additional meta-data with it. Linking to other features can be decided once we other features are complete and we have a working this feature.For now, is it ok to have a recycler view for displaying pics, something insta type? And shall there be a separate fragment or an activity for this?

@Rushi98 Rushi98 added approved This issue has been approved by maintainers. Grab them before others. and removed on hold This issue depends on other issues labels May 22, 2018
@Rushi98
Copy link
Member Author

Rushi98 commented May 23, 2018

Separate activity for the main feature. And a fragment to be shown in home activity

@Rushi98
Copy link
Member Author

Rushi98 commented Jun 6, 2018

@aayushsingla See https://developer.android.com/training/camera/photobasics to see how to take photos with existing camers apps.

@aayushsingla
Copy link
Member

@Rushi98 the image chooser i have used gives this option in the status bar when we go to select the image

@Rushi98
Copy link
Member Author

Rushi98 commented Jun 6, 2018

Why use an external library when native code is easily available?

@aayushsingla
Copy link
Member

External Library allows you to select images already stored on phone.For this you wont need any file explorer and you can also limit the number of images to be selected.It also takes care of most things like asking for storage permission. The library is very small.So, i guess we dont need to worry. And it can also be customised. :p

@Rushi98
Copy link
Member Author

Rushi98 commented Jun 6, 2018

Native camera apps also allows to select previously captured images. (It also has advantage of filtering out non photo images. So no cat gifs :P ) User is already familiar with native camera ui.

@aayushsingla
Copy link
Member

I don't think Ui will be a problem because it is simpler then the actual one. However the major advantages of using image picker were:
1.) it doesnot require prescence of any external app like gallery, camera or photos app.
2.)It takes care of all the the permissions to be asked and the cases user denies the permission.

If you still think native camera app is better, I will remove the lib in future commits.

@Rushi98
Copy link
Member Author

Rushi98 commented Jun 7, 2018

I do think it's better to use native capabilities than third party libraries as we have all control up from basics.

@tanmaydixit
Copy link
Member

This will continue in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue has been approved by maintainers. Grab them before others. discussion Now is a good time to discuss about this feature. Hop in! feature New feature to be added
Projects
None yet
Development

No branches or pull requests

3 participants