-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
live photo upload system #5
Comments
are we going to do this? if yes, can i take this up? |
There are some details we need to finalize:
After these (and more if need arises) are resolved, you can take it up. |
Any suggestion from your side for storing pics? |
You can start with any of the two you are comfortable with. Try to keep the code for upload etc. modular so that if there is some issue (ex. we hit 5 GB limit of cloud storage) we are able to swap one for another easily. |
I was thinking to use Flickr API. i think it is cool for all our needs. |
We can't. Flickr guidelines specifically ask not to use their service as replacement for content server and we should respect that. |
So,if we cant use their API then i will use google drive REST API for it. In database we will use a separate node to store urls for photo and the additional meta-data with it. Linking to other features can be decided once we other features are complete and we have a working this feature.For now, is it ok to have a recycler view for displaying pics, something insta type? And shall there be a separate fragment or an activity for this? |
Separate activity for the main feature. And a fragment to be shown in home activity |
@aayushsingla See https://developer.android.com/training/camera/photobasics to see how to take photos with existing camers apps. |
@Rushi98 the image chooser i have used gives this option in the status bar when we go to select the image |
Why use an external library when native code is easily available? |
External Library allows you to select images already stored on phone.For this you wont need any file explorer and you can also limit the number of images to be selected.It also takes care of most things like asking for storage permission. The library is very small.So, i guess we dont need to worry. And it can also be customised. :p |
Native camera apps also allows to select previously captured images. (It also has advantage of filtering out non photo images. So no cat gifs :P ) User is already familiar with native camera ui. |
I don't think Ui will be a problem because it is simpler then the actual one. However the major advantages of using image picker were: If you still think native camera app is better, I will remove the lib in future commits. |
I do think it's better to use native capabilities than third party libraries as we have all control up from basics. |
This will continue in #40 |
The text was updated successfully, but these errors were encountered: