Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing some healthChecks options for Express Status Monitor #23

Open
ritvij14 opened this issue Jul 20, 2020 · 1 comment
Open

Changing some healthChecks options for Express Status Monitor #23

ritvij14 opened this issue Jul 20, 2020 · 1 comment

Comments

@ritvij14
Copy link
Member

What needs to be changed:

  • For now, since we don't know the API endpoints, we have no prefix for them. The healthChecks of spans option for Express Status Monitor made for issue Setup Express Setup monitor #15 needs a proper API prefix to do proper status check.

  • The host for the same property has been set to localhost. Need to change it as we would need in future after hosting the backend server.

Code is in pull request #21.
@ritvij14 ritvij14 mentioned this issue Jul 20, 2020
Merged
13 tasks
@shamanX86
Copy link
Member

Issue to be closed now that the PR has been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shamanX86 @ritvij14