-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soul Knight feature request #723
Comments
@a906358951 hello,i am interested in this feature,and I will try do it |
It seems that java-faker is not maintained on a regular basis. Would you consider creating a similar PR in https://github.com/serpro69/kotlin-faker instead, @Uncle-Road ? Or else, do you mind if I use the yml files from your PR in the kotlin-faker myself? |
@serpro69 hello, free to use the yml files. And i have to prepare my final exam in recent month. |
Hi @Uncle-Road , this faker is already part of Datafaker: https://github.com/datafaker-net/datafaker |
hello,bro. and i check the date and the soulknight.yml. find he is copy my code to soul knight. |
Hi @Uncle-Road, my apologies, that 'he' you are referring to is probably me, and I ported this code to Datafaker. The code is attributed to you, and you are also mentioned in the release notes, but I'm sorry you're angry about this. |
@epragtbeamtree hey, bro. I understand the situation. There may be some misunderstanding between us. If you mention me in the release notes, it will be fine. And I saw your comment, misunderstood your meaning before |
@Uncle-Road oki, no worries, just want to make sure I don't step on anyone's toes. I love your contributions, and it's a shame javafaker is dead, but we're trying to continue the journey at Datafaker, and kotlin-faker seems like a great project too! |
@epragtbeamtree Actually javafaker is an open-source project required by my software engineering course at SUSTech. We're nearing the end of the semester, and I'll be putting my previous PRs into these two newest projects(Datafaker, kotlin-faker) over the summer vacation, and I've been preparing for my final exams recent month. |
@Uncle-Road would it be an option to suggest Datafaker as an alternative at your course? I'm even happy to assist students in their work if needed. |
@bodiam hey, bro. Thanks for your suggestion. And I will report this situation to the teacher Mrs. Chen and ask her to replace it with datafaker next semester. (The number of issues is very important for Mrs. Chen to choose projects. Could you consider mentioning more issues) |
@Uncle-Road that would be amazing, thank you. There's a long list of fakers which will need implementing, and they make excellent candidates for a engineering course. You can send me an email if you need a list, or I can make a list of issues specifically for you. I think I can make 30 or 40 issues easily, and mark them as reserved for you. Lastly, I want to thank you for how you handled our earlier miscommunication. That was incredibly mature, and I appreciate it. |
Is your feature request related to a problem? Please describe.
Soul Knight is loved by many young people. It is a classic pixel adventure game with many elements. Please consider adding its feature.
Describe the solution you'd like
Characters, Weapons, Statues, Bosses, Enemies, Talents, etc
The text was updated successfully, but these errors were encountered: